agora inbox for pgsql-sql@postgresql.org  
help / color / mirror / Atom feed
TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef
5+ messages / 2 participants
[nested] [flat]

* TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef
@ 2017-05-22 10:51 Sebastien FLAESCH <sf@4js.com>
  2017-05-22 10:57 ` Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
  2017-05-22 11:07 ` Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
  2017-05-22 12:04 ` Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 3 replies; 5+ messages in thread

From: Sebastien FLAESCH @ 2017-05-22 10:51 UTC (permalink / raw)
  To: pgsql-sql

Hi all,

Testing with Postgresql 9.6rc1 (but also detected with prior versions):

It is normal that a TRUNCATE TABLE statement changes the table/sequence relation in pg_attrdef?

test1=> create table mytab ( pkey serial, name varchar(10) );
test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');
                 adsrc
-------------------------------------
  nextval('mytab_pkey_seq'::regclass)
(1 row)

test1=> truncate table mytab;
TRUNCATE TABLE
test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');
  adsrc
-------
(0 rows)

test1=> select adrelid, adsrc from pg_attrdef where adsrc like '%mytab%';
  adrelid |                adsrc
---------+-------------------------------------
  6904163 | nextval('mytab_pkey_seq'::regclass)
(1 row)


Are we mis-using the condition (p.relfilenode = a.adrelid) in the first SELECT?

How can we easily check if a table is defined with a SERIAL type?

Thanks!
Seb


-- 
Sent via pgsql-sql mailing list (pgsql-sql@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-sql



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef
  2017-05-22 10:51 TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
@ 2017-05-22 10:57 ` Sebastien FLAESCH <sf@4js.com>
  2 siblings, 0 replies; 5+ messages in thread

From: Sebastien FLAESCH @ 2017-05-22 10:57 UTC (permalink / raw)
  To: pgsql-sql

We will test with 9.6.3 too.

Seb

On 05/22/2017 12:51 PM, Sebastien FLAESCH wrote:
> Hi all,
>
> Testing with Postgresql 9.6rc1 (but also detected with prior versions):
>
> It is normal that a TRUNCATE TABLE statement changes the table/sequence relation in pg_attrdef?
>
> test1=> create table mytab ( pkey serial, name varchar(10) );
> test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');
>                 adsrc
> -------------------------------------
>  nextval('mytab_pkey_seq'::regclass)
> (1 row)
>
> test1=> truncate table mytab;
> TRUNCATE TABLE
> test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');
>  adsrc
> -------
> (0 rows)
>
> test1=> select adrelid, adsrc from pg_attrdef where adsrc like '%mytab%';
>  adrelid |                adsrc
> ---------+-------------------------------------
>  6904163 | nextval('mytab_pkey_seq'::regclass)
> (1 row)
>
>
> Are we mis-using the condition (p.relfilenode = a.adrelid) in the first SELECT?
>
> How can we easily check if a table is defined with a SERIAL type?
>
> Thanks!
> Seb
>
>



-- 
Sent via pgsql-sql mailing list (pgsql-sql@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-sql



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef
  2017-05-22 10:51 TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
@ 2017-05-22 11:07 ` Sebastien FLAESCH <sf@4js.com>
  2017-05-22 11:14   ` Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
  2 siblings, 1 reply; 5+ messages in thread

From: Sebastien FLAESCH @ 2017-05-22 11:07 UTC (permalink / raw)
  To: pgsql-sql

Seems that the correct join condition should be:

     (pg_class.oid = pg_attrdef.adrelid)

I don't know why we have used pg_class.relfilenode...

So this should be the correct SELECT statement:

test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.oid = a.adrelid) where lower(p.relname) = lower('mytab');
                 adsrc
-------------------------------------
  nextval('mytab_pkey_seq'::regclass)
(1 row)


Can someone confirm?

Thanks!
Seb


On 05/22/2017 12:51 PM, Sebastien FLAESCH wrote:
> Hi all,
>
> Testing with Postgresql 9.6rc1 (but also detected with prior versions):
>
> It is normal that a TRUNCATE TABLE statement changes the table/sequence relation in pg_attrdef?
>
> test1=> create table mytab ( pkey serial, name varchar(10) );
> test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');
>                 adsrc
> -------------------------------------
>  nextval('mytab_pkey_seq'::regclass)
> (1 row)
>
> test1=> truncate table mytab;
> TRUNCATE TABLE
> test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');
>  adsrc
> -------
> (0 rows)
>
> test1=> select adrelid, adsrc from pg_attrdef where adsrc like '%mytab%';
>  adrelid |                adsrc
> ---------+-------------------------------------
>  6904163 | nextval('mytab_pkey_seq'::regclass)
> (1 row)
>
>
> Are we mis-using the condition (p.relfilenode = a.adrelid) in the first SELECT?
>
> How can we easily check if a table is defined with a SERIAL type?
>
> Thanks!
> Seb
>
>



-- 
Sent via pgsql-sql mailing list (pgsql-sql@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-sql



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef
  2017-05-22 10:51 TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
  2017-05-22 11:07 ` Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
@ 2017-05-22 11:14   ` Sebastien FLAESCH <sf@4js.com>
  0 siblings, 0 replies; 5+ messages in thread

From: Sebastien FLAESCH @ 2017-05-22 11:14 UTC (permalink / raw)
  To: pgsql-sql

Obviously pg_class.relfilenode can change when truncating tables:

test1=> select relfilenode from pg_class where relname = 'mytab';
  relfilenode
-------------
      6904188
(1 row)


test1=> truncate table mytab;


TRUNCATE TABLE
test1=> select relfilenode from pg_class where relname = 'mytab';
  relfilenode
-------------
      6904189
(1 row)


Seb

On 05/22/2017 01:07 PM, Sebastien FLAESCH wrote:
> Seems that the correct join condition should be:
>
>     (pg_class.oid = pg_attrdef.adrelid)
>
> I don't know why we have used pg_class.relfilenode...
>
> So this should be the correct SELECT statement:
>
> test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.oid = a.adrelid) where lower(p.relname) = lower('mytab');
>                 adsrc
> -------------------------------------
>  nextval('mytab_pkey_seq'::regclass)
> (1 row)
>
>
> Can someone confirm?
>
> Thanks!
> Seb
>
>
> On 05/22/2017 12:51 PM, Sebastien FLAESCH wrote:
>> Hi all,
>>
>> Testing with Postgresql 9.6rc1 (but also detected with prior versions):
>>
>> It is normal that a TRUNCATE TABLE statement changes the table/sequence relation in pg_attrdef?
>>
>> test1=> create table mytab ( pkey serial, name varchar(10) );
>> test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');
>>                 adsrc
>> -------------------------------------
>>  nextval('mytab_pkey_seq'::regclass)
>> (1 row)
>>
>> test1=> truncate table mytab;
>> TRUNCATE TABLE
>> test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');
>>  adsrc
>> -------
>> (0 rows)
>>
>> test1=> select adrelid, adsrc from pg_attrdef where adsrc like '%mytab%';
>>  adrelid |                adsrc
>> ---------+-------------------------------------
>>  6904163 | nextval('mytab_pkey_seq'::regclass)
>> (1 row)
>>
>>
>> Are we mis-using the condition (p.relfilenode = a.adrelid) in the first SELECT?
>>
>> How can we easily check if a table is defined with a SERIAL type?
>>
>> Thanks!
>> Seb
>>
>>
>
>
>



-- 
Sent via pgsql-sql mailing list (pgsql-sql@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-sql



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef
  2017-05-22 10:51 TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
@ 2017-05-22 12:04 ` Tom Lane <tgl@sss.pgh.pa.us>
  2 siblings, 0 replies; 5+ messages in thread

From: Tom Lane @ 2017-05-22 12:04 UTC (permalink / raw)
  To: Sebastien FLAESCH <sf@4js.com>; +Cc: pgsql-sql

Sebastien FLAESCH <sf@4js.com> writes:
> It is normal that a TRUNCATE TABLE statement changes the table/sequence relation in pg_attrdef?

It is normal for TRUNCATE, as well as several other kinds of DDL, to
change relfilenode.

> test1=> select a.adsrc from pg_class p join pg_attrdef a on (p.relfilenode = a.adrelid) where lower(p.relname) = lower('mytab');

This query is simply wrong; the join column should be p.oid.  See the
system catalog definitions,

https://www.postgresql.org/docs/current/static/catalogs.html

			regards, tom lane


-- 
Sent via pgsql-sql mailing list (pgsql-sql@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-sql



^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2017-05-22 12:04 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-05-22 10:51 TRUNCATE TABLE corrupts pg_class.relfilenode = pg_attrdef.pg_attrdef Sebastien FLAESCH <sf@4js.com>
2017-05-22 10:57 ` Sebastien FLAESCH <sf@4js.com>
2017-05-22 11:07 ` Sebastien FLAESCH <sf@4js.com>
2017-05-22 11:14   ` Sebastien FLAESCH <sf@4js.com>
2017-05-22 12:04 ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox