To: "Christopher Kings-Lynne" <chriskl@familyhealth.com.au>
Cc: pgsql-sql@postgresql.org
Subject: Re: Bug with dump/restore when using UNION and ORDER BY in views 
In-reply-to: <00a801c23b77$24bd2dc0$0200a8c0@SOL> 
References: <036501c23b32$5c5149f0$6b97f181@speed>
	<6562.1028430401@sss.pgh.pa.us>
	<00a801c23b77$24bd2dc0$0200a8c0@SOL>
Comments: In-reply-to "Christopher Kings-Lynne" <chriskl@familyhealth.com.au>
	message dated "Sun, 04 Aug 2002 13:24:00 +0800"
Date: Sun, 04 Aug 2002 01:30:37 -0400
Message-ID: <7639.1028439037@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

"Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:
>> Yeah.  This is fixed in current sources, and I back-patched it into
>> the REL7_2 branch, but current plans don't seem to include a 7.2.2
>> release --- we'll be going straight to 7.3 beta instead.

> Is it worth doing a 7.2.2 patch that will dump people's foreign keys as
> ALTER TABLE/ADD FOREIGN KEY instead of a bunch of CREATE CONSTRAINT
> TRIGGERs, so that they actually become constraints in 7.3?

I don't think it's any easier to do that as a backpatch than as new
functionality in 7.3 pg_dump.  As far as the general issue of a 7.2.2
release goes, I'm personally in favor of one --- there are several
important bugfixes in the 7.2 branch right now --- but I don't do the
gruntwork for patch releases, so I can't complain too much.

> Also Tom - did you check if you can CREATE CONSTRAINT TRIGGER on a dropped
> column - I think I neglected to look at that in the patch I submitted
> originally.

I'm pretty sure that won't get past the ATTNAME cache patches, but try
it...

			regards, tom lane