MIME-Version: 1.0
References: 
 <CAJyMCYJ+JGpHtpV36UP+kUAW4LoprmgbgDPLCpe_8A0xbe=GZA@mail.gmail.com>
 <CAJyMCYLL-mMuCfXT8M1kD-=6=r8YHHrSGbT-rN25vCwtVyr1jg@mail.gmail.com>
 <CAEzk6ffszUabGjDhBOCZqTP0PoMzLaJtnu+=ye2snMVSOy=b4w@mail.gmail.com>
 <CAJyMCYLvymAS+7DoiHGs2zHKGigQj7waGzdXWbo+3xBUzi4Mew@mail.gmail.com>
 <CAJyMCYJDiY6hoLdtM=T2nc8rnZTxBbNOr0mHsJ5v6OPtes6B0Q@mail.gmail.com>
In-Reply-To: 
 <CAJyMCYJDiY6hoLdtM=T2nc8rnZTxBbNOr0mHsJ5v6OPtes6B0Q@mail.gmail.com>
From: Geoff Winkless <pgsqladmin@geoff.dj>
Date: Thu, 20 Jul 2023 15:51:35 +0100
Message-ID: 
 <CAEzk6fcfXk_-UweJZ_hFWecDAs_0ECd27Q_r_=o1V78k5xBBuA@mail.gmail.com>
Subject: Re: TSQL To Postgres - Unpivot/Union All
To: Anthony Apollis <anthony.apollis@gmail.com>
Cc: pgsql-general@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAEzk6fcfXk_-UweJZ_hFWecDAs_0ECd27Q_r_%3Do1V78k5xBBuA%40mail.gmail.com>
Precedence: bulk

On Thu, 20 Jul 2023 at 15:28, Anthony Apollis <anthony.apollis@gmail.com> wrote:
> I am attaching my TSQL and Postgres SQL:

You're still missing some CREATEs, for example for temp_FieldFlowsFact.

Even assuming your columns list is correct, I would still (and as a
matter of habit) include the target column list in your INSERT
statements, if only to make your own life easier, but especially
because any later changes to the tables could end up shifting the
position of the columns.

Certainly it will be easier for anyone else trying to disentangle the SQL later.

As an aside, can you clarify whether you mean temporal tables (and are
you using a temporal tables extension)? Or should that read
"temporary"?

Geoff