X-Original-To: pgsql-sql-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 85ACB536E9 for ; Mon, 2 May 2005 16:28:28 -0300 (ADT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 84540-02 for ; Mon, 2 May 2005 19:28:25 +0000 (GMT) Received: from bcbssc.com (mail1.bcbssc.com [207.19.198.69]) by svr1.postgresql.org (Postfix) with ESMTP id E81435364B for ; Mon, 2 May 2005 16:28:23 -0300 (ADT) Received: from ([207.19.198.73]) by mail1.bcbssc.com with ESMTP id KP-TRPV8.21669683; Mon, 02 May 2005 15:27:07 -0400 X-Internal-ID: 426C39E20000BE3B Received: from companiongroup.com (207.19.198.73) by companion1.companiongroup.com (NPlex 2.0.108); 2 May 2005 15:27:01 -0400 Message-ID: Date: Mon, 2 May 2005 15:27:00 -0400 From: "CHRIS HOOVER" To: lucas@presserv.org Cc: pgsql-sql@postgresql.org Subject: Re: Record Log Trigger X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests= X-Spam-Level: X-Archive-Number: 200505/23 X-Sequence-Number: 21336 One change you might want to look at is not using the now() function. According to the docs, the now() function always returns the start of the transaction time. So, if your code is using transaction blocks, the time may not be what you are expecting. This is what I had do to in my trigger to get the current clock time: to_char(to_timestamp(timeofday(),\'Dy Mon DD HH24:MI:SS.US YYYY\') HTH, Chris ------------------( Forwarded letter 1 follows )--------------------- Date: Mon, 02 May 2005 16:10:46 -0300 To: pgsql-sql@postgresql.org.comp From: lucas@presserv.org.comp Sender: pgsql-sql-owner+m21335@postgresql.org.comp Subject: [SQL] Record Log Trigger Hi all, I am building a database in postgresql and I made a function that returns the system time and the current user... like this: CREATE OR REPLACE FUNCTION generate_idx() returns text as $$ select to_char(now(),'YYYYMMDDHHMISSUSTZ')||CURRENT_USER; $$ language 'SQL'; CREATE OR REPLACE FUNCTION TG_idxm() RETURNS trigger AS $$ BEGIN NEW.idxm = generate_idx(); RETURN NEW; END; $$ LANGUAGE plpgsql; And my all tables have the "idxm" field, its something like a log for the record, to know Who and When the record have changed. I.e: CREATE TABLE products( id serial primary key, description varchar(50), ... idxm varchar(100) ); CREATE TRIGGER TG_products_idxm BEFORE INSERT or UPDATE on products FOR EACH ROW EXECUTE PROCEDURE TG_idxm(); Okay, it runs fine... but my question is: Is it right??? In the future (when the database will be bigger with many of millions records) this functions for each table will depreceate my database performance??? Is there any other way to build it??? Thank you ---------------------------(end of broadcast)--------------------------- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faq