Received: from ra.sai.msu.su (ra.sai.msu.su [158.250.29.2]) by hub.org (8.9.3/8.9.3) with ESMTP id CAA70125; Mon, 26 Jul 1999 02:49:47 -0400 (EDT) (envelope-from oleg@sai.msu.su) Received: from ra (ra [158.250.29.2]) by ra.sai.msu.su (8.9.1/8.9.1) with SMTP id KAA12791; Mon, 26 Jul 1999 10:49:11 +0400 (MSD) Date: Mon, 26 Jul 1999 10:49:11 +0400 (MSD) From: Oleg Bartunov X-Sender: megera@ra To: Vadim Mikheev cc: Tom Lane , pgsql-hackers@postgreSQL.org, pgsql-sql@postgreSQL.org Subject: Re: [SQL] inserts/updates problem under stressing ! In-Reply-To: <379BFF7E.BD57269E@krs.ru> Message-ID: Organization: Sternberg Astronomical Institute (Moscow University) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Mon, 26 Jul 1999, Vadim Mikheev wrote: > Date: Mon, 26 Jul 1999 14:26:06 +0800 > From: Vadim Mikheev > To: Oleg Bartunov > Cc: Tom Lane , pgsql-hackers@postgreSQL.org, > pgsql-sql@postgreSQL.org > Subject: Re: [SQL] inserts/updates problem under stressing ! > > Oleg Bartunov wrote: > > > > > > > > SELECT FOR UPDATE will not help: if there was no record for > > > particular key then nothing will be locked and two records with > > > the same key will be inserted. > > > > > > Oleg, use LOCK IN SHARE ROW EXCLUSIVE MODE. > > > > Thanks Vadim. Just tried this, but still I see a difference between > > count hits (accumulated) from db and access_log. In my test these numbers are: > > 95 and 109. So I lost 14 hits ! And no errors ! > > In my handler I have now: > > > > my $sth = $dbh->do("LOCK TABLE hits IN SHARE ROW EXCLUSIVE MODE"); > > my $sth = $dbh->do("SELECT acc_hits($1)") || die $dbh->errstr; > > > > am I right ? > > You should run LOCK and SELECT inside BEGIN/END (i.e. in > the same transaction), do you? Good question. I use perl DBI interface to work with postgres and I supposed it does transaction automatically. Will check it. Aha, got the problem. Now everything works !!! Tnanks again, Oleg So, here is a working handler to *accumulate* hit statistics. package Apache::HitsDBI; use Apache::Constants qw(:common); use strict; # preloaded in startup.pl #use DBI (); sub handler { my $orig = shift; my $url = $orig->uri; if ( $orig->args() =~ /msg_id=(\d+)/ ) { my $dbh = DBI->connect("dbi:Pg:dbname=discovery") || die DBI->errstr; $dbh->{AutoCommit} = 0; my $sth = $dbh->do("LOCK TABLE hits IN SHARE ROW EXCLUSIVE MODE") || die $dbh->errstr; my $sth = $dbh->do("SELECT acc_hits($1)") || die $dbh->errstr; my $rc = $dbh->commit || die $dbh->errstr; } return OK; } 1; __END__ Oleg > > Vadim > _____________________________________________________________ Oleg Bartunov, sci.researcher, hostmaster of AstroNet, Sternberg Astronomical Institute, Moscow University (Russia) Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/ phone: +007(095)939-16-83, +007(095)939-23-83