Received: from localhost (maia-1.hub.org [200.46.204.191])
	by postgresql.org (Postfix) with ESMTP id 882879FA23F
	for <pgsql-sql-postgresql.org@postgresql.org>;
	Fri,  1 Dec 2006 14:58:14 -0400 (AST)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.191]) (amavisd-new, port 10024)
	with ESMTP id 91894-10 for <pgsql-sql-postgresql.org@postgresql.org>;
	Fri,  1 Dec 2006 14:58:03 -0400 (AST)
X-Greylist: domain auto-whitelisted by SQLgrey-1.7.4
Received: from py-out-1112.google.com (py-out-1112.google.com
 [64.233.166.176])
	by postgresql.org (Postfix) with ESMTP id AB96B9FA231
	for <pgsql-sql@postgresql.org>; Fri,  1 Dec 2006 14:58:02 -0400 (AST)
Received: by py-out-1112.google.com with SMTP id d32so1865575pye
	for <pgsql-sql@postgresql.org>; Fri, 01 Dec 2006 10:58:02 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
	b=WczPe/jdGjWX8elA9M5e2Pn2Hcd4XL+r9y+jN5CEUJVXY76lamEE3u9pL0/kXkTAmmSZGUFchwEKJwPeRRVxYgncGXpIk45a7rjJUpdQFerxl9Yw48o9677swe+hAhCaIgK43f8p2MSyEd1qYdMnTFbdCKnS94pGJCY/N/8AXxw=
Received: by 10.35.96.11 with SMTP id y11mr9283835pyl.1164999482077;
	Fri, 01 Dec 2006 10:58:02 -0800 (PST)
Received: by 10.35.80.10 with HTTP; Fri, 1 Dec 2006 10:58:02 -0800 (PST)
Message-ID: <a97c77030612011058q513d02baofb496fd2ea7fa1c6@mail.gmail.com>
Date: Sat, 2 Dec 2006 00:28:02 +0530
From: "Rajesh Kumar Mallah" <mallah.rajesh@gmail.com>
To: "Tom Lane" <tgl@sss.pgh.pa.us>
Subject: Re: calling elog possibly causing problem in DirectFunctionCall1
Cc: pgsql-sql@postgresql.org
In-Reply-To: <628.1164995263@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_6674_3348573.1164999482010"
References: <a97c77030612010840o3436b7bcje1cdfc507c009f3b@mail.gmail.com>
	<628.1164995263@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200612/13
X-Sequence-Number: 26969

------=_Part_6674_3348573.1164999482010
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 12/1/06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> "Rajesh Kumar Mallah" <mallah.rajesh@gmail.com> writes:
> >   data->time_stamp =
> >     DirectFunctionCall1(timestamptz_in, CStringGetDatum("now"));
>
> This code is incorrect, as timestamptz_in takes three arguments.


replaced it with:

data->time_stamp = DirectFunctionCall3(timestamptz_in,
                CStringGetDatum("now"),
                ObjectIdGetDatum(InvalidOid),
                Int32GetDatum(-1))

now it works fine. (code lifted from contrib/spi/moddatetime.c(line 73)
hopefully its correct.

                        regards, tom lane
>

------=_Part_6674_3348573.1164999482010
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<br><br><div><span class="gmail_quote">On 12/1/06, <b class="gmail_sendername">Tom Lane</b> &lt;<a href="mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
&quot;Rajesh Kumar Mallah&quot; &lt;<a href="mailto:mallah.rajesh@gmail.com">mallah.rajesh@gmail.com</a>&gt; writes:<br>&gt;&nbsp;&nbsp; data-&gt;time_stamp =<br>&gt;&nbsp;&nbsp;&nbsp;&nbsp; DirectFunctionCall1(timestamptz_in, CStringGetDatum(&quot;now&quot;));
<br><br>This code is incorrect, as timestamptz_in takes three arguments.</blockquote><div><br>replaced it with:<br><br>data-&gt;time_stamp = DirectFunctionCall3(timestamptz_in,<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; CStringGetDatum(&quot;now&quot;),
<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; ObjectIdGetDatum(InvalidOid),<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Int32GetDatum(-1))<br><br>now it works fine. (code lifted from contrib/spi/moddatetime.c(line 73)<br>hopefully its correct.<br> </div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;regards, tom lane<br></blockquote></div><br>

------=_Part_6674_3348573.1164999482010--