Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VYLLv-0002gX-RB for pgsql-students@arkaria.postgresql.org; Mon, 21 Oct 2013 19:41:24 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1VYLLv-0006eB-1z for pgsql-students@arkaria.postgresql.org; Mon, 21 Oct 2013 19:41:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VYLLt-0006cC-2J; Mon, 21 Oct 2013 19:41:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VYLLq-0005ox-2V; Mon, 21 Oct 2013 19:41:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id r9LJfG7I003820; Mon, 21 Oct 2013 15:41:16 -0400 From: Tom Lane To: Alexander Korotkov cc: Heikki Linnakangas , Stas Kelvich , Robert Haas , pgsql-hackers , pgsql-students@postgresql.org Subject: Re: [HACKERS] Cube extension point support // GSoC'13 In-reply-to: References: <23364502-F542-4553-A658-4D3A2B6FCFA9@gmail.com> <5236A9BC.3030000@vmware.com> <5258038C.9070409@vmware.com> <52657B1C.7050906@vmware.com> Comments: In-reply-to Alexander Korotkov message dated "Mon, 21 Oct 2013 23:18:40 +0400" Date: Mon, 21 Oct 2013 15:41:16 -0400 Message-ID: <3819.1382384476@sss.pgh.pa.us> X-Pg-Spam-Score: -2.3 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-students Precedence: bulk Sender: pgsql-students-owner@postgresql.org Alexander Korotkov writes: > On Mon, Oct 21, 2013 at 11:06 PM, Heikki Linnakangas < > hlinnakangas@vmware.com> wrote: >> I guess it can't happen. Or is it possible that a toasted value that came >> from disk will be passed to these functions, without detoasting them >> somewhere along the way? Not sure. > I will ask Teodor about it. When situation will be completely clear we > should cleanup confusing comments. I believe the reason GIST has compress/decompress functions is not for TOAST (they predate that, if memory serves), but to allow the on-disk representation of an index entry to be different from the data type's normal representation in other ways --- think lossy storage in particular. It's possible that the code in cube's decompress/decompress functions is unnecessary because cube doesn't actually do any such compression; the code might've been copy-pasted from somewhere else without adequate thought about whether it was useful for cubes. I'd want to see some discussion about why it's okay to change it before we do so, though. In any case it seems separate from the claimed purpose of this patch and thus better done in a different patch. regards, tom lane -- Sent via pgsql-students mailing list (pgsql-students@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-students