Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VLSbu-0005Ig-54 for pgsql-students@arkaria.postgresql.org; Mon, 16 Sep 2013 06:48:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.80) (envelope-from ) id 1VLSbt-0004Uu-LV for pgsql-students@arkaria.postgresql.org; Mon, 16 Sep 2013 06:48:37 +0000 Received: from makus.postgresql.org ([2001:4800:7903:4::125]) by malur.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VLSbt-0004Uk-4k; Mon, 16 Sep 2013 06:48:37 +0000 Received: from smtp-outbound-1.vmware.com ([208.91.2.12]) by makus.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1VLSbo-0007jz-Qx; Mon, 16 Sep 2013 06:48:35 +0000 Received: from sc9-mailhost3.vmware.com (sc9-mailhost3.vmware.com [10.113.161.73]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 82341289D0; Sun, 15 Sep 2013 23:48:31 -0700 (PDT) Received: from zcs-prod-ext-mta-1.vmware.com (zcs-prod-ext-mta-1.vmware.com [10.113.62.223]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id 7FEB6401FC; Sun, 15 Sep 2013 23:48:31 -0700 (PDT) Received: from zcs-prod-ext-mta-1.vmware.com (localhost.localdomain [127.0.0.1]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTP id 5D33D12002F; Sun, 15 Sep 2013 23:55:22 -0700 (PDT) Received: from [192.168.1.90] (zimbra-prod-ext-proxy-vip.vmware.com [10.113.63.87]) by zcs-prod-ext-mta-1.vmware.com (Postfix) with ESMTPSA; Sun, 15 Sep 2013 23:55:21 -0700 (PDT) Message-ID: <5236A9BC.3030000@vmware.com> Date: Mon, 16 Sep 2013 09:48:28 +0300 From: Heikki Linnakangas Organization: VMware User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Stas Kelvich CC: pgsql-hackers , pgsql-students@postgresql.org Subject: Re: [HACKERS] Cube extension point support // GSoC'13 References: <23364502-F542-4553-A658-4D3A2B6FCFA9@gmail.com> In-Reply-To: <23364502-F542-4553-A658-4D3A2B6FCFA9@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -7.6 (-------) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-students Precedence: bulk Sender: pgsql-students-owner@postgresql.org On 12.07.2013 14:57, Stas Kelvich wrote: > Hello. > > here is a patch adding to cube extension support for compressed representation of point cubes. If cube is a point, i.e. has coincident lower left and upper right corners, than only one corner is stored. First bit of the cube header indicates whether the cube is point or not. Few moments: > > * Patch preserves binary compatibility with old indices > * All functions that create cubes from user input, check whether it is a point or not > * All internal functions that can return cubes takes care of all cases where a cube might become a point Great! cube_is_point() needs to still handle old-style points. An NDBOX without the point-flag set, where the ll and ur coordinates for each dimension are the same, still needs to be considered a point. Even if you are careful to never construct such structs in the code, they can be present on-disk if you have upgraded from an earlier version with pg_upgrade. Same in cube_out(). > * Added tests for checking correct point behavior You'll need to adjust all the expected output files, not only cube_1.out. > Also this patch includes adapted Alexander Korotkov's patch with kNN-based ordering operator, which he wrote for postgresql-9.0beta1 with knngist patch. More info there http://www.postgresql.org/message-id/AANLkTimhFaq6hCibRnk0tlcQMIyhYWHwAQ2ZD87wbH86@mail.gmail.com To make review easier, it would be better to keep that as a separate patch, actually. Could you split it up again, please? - Heikki -- Sent via pgsql-students mailing list (pgsql-students@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-students