Received: from maia.hub.org (maia-2.hub.org [200.46.204.251]) by mail.postgresql.org (Postfix) with ESMTP id C907B632521 for ; Tue, 15 Jun 2010 04:13:34 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.251]) (amavisd-maia, port 10024) with ESMTP id 10424-08 for ; Tue, 15 Jun 2010 07:13:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-yw0-f187.google.com (mail-yw0-f187.google.com [209.85.211.187]) by mail.postgresql.org (Postfix) with ESMTP id E2C00632322 for ; Tue, 15 Jun 2010 04:13:26 -0300 (ADT) Received: by ywh17 with SMTP id 17so2582090ywh.1 for ; Tue, 15 Jun 2010 00:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:message-id:references:to :x-mailer; bh=i/upa8vW+YA0xtOmNwv3lzc56kUVm+32ZoEEC6Zgy4c=; b=QM61awrSrb4aRzF70HlnLp+U6Fi3eTSLYWJi1nxYeiLIDdYskxdF7l4EWtM0LuCOIj rz26KU5GKgq6I0DK9RC1KDW00KXjhGQfnU7ZVf10GUaafjcqKJUFk3M5TnkCUsByqZ2L fT8FpDcJQzZri6JjleZKMqobOPiED59tG79gA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to:x-mailer; b=PXBrPQCr3md9XmglGmAgS88gS8CelNzgaKBmCrf4cXg4kFW9NUTvhwVcM7SOlSh3q0 QDwYQPQuWmwwp4f9kdl539eN0saqllLq9i32+rG7yUndKQquGGUOfo6iXZkBAhW3JQ+u vtmeBB0GNyT6uKKtqm4qX87VL7B1PioBVmpIY= Received: by 10.150.209.7 with SMTP id h7mr8111859ybg.14.1276586003415; Tue, 15 Jun 2010 00:13:23 -0700 (PDT) Received: from [10.84.143.183] ([64.197.120.2]) by mx.google.com with ESMTPS id v2sm37670794ybe.47.2010.06.15.00.13.20 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 15 Jun 2010 00:13:22 -0700 (PDT) Subject: Re: 9.0Beta2 Build on Mac (64 bit) of pg_upgrade fails with duplicate symbols Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: multipart/alternative; boundary=Apple-Mail-45--221433311 From: Chris Ruprecht In-Reply-To: <201006150212.o5F2CTb08070@momjian.us> Date: Tue, 15 Jun 2010 03:13:13 -0400 Cc: pgsql-testers@postgresql.org Message-Id: <0B84FDF1-88BF-4257-80BB-9881469B4B28@gmail.com> References: <201006150212.o5F2CTb08070@momjian.us> To: Bruce Momjian , Josh Berkus X-Mailer: Apple Mail (2.1078) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-0.918 tagged_above=-10 required=5 tests=BAYES_00=-1.9, HTML_FONT_FACE_BAD=0.981, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001 X-Spam-Level: X-Archive-Number: 201006/20 X-Sequence-Number: 134 --Apple-Mail-45--221433311 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Sorry for the late reply Josh, but apparently, Bruce already has a fix = for the issue - Thanks Bruce!! Thanks a bunch, I'll put the patch in when I get back home on Saturday. .... if only my commercial RDBMS provider had turn-around times like you = guys .... best regards, chris --=20 chris ruprecht specialist in obscure details On Jun 14, 2010, at 22:12 , Bruce Momjian wrote: > Chris Ruprecht wrote: >> I'm building the contrib modules and get this: >>=20 >> gcc -no-cpp-precomp -O3 -fno-common -arch x86_64 -Wall = -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement = -Wendif-labels -fno-strict-aliasing -fwrapv check.o controldata.o dump.o = exec.o file.o function.o info.o option.o page.o pg_upgrade.o = relfilenode.o server.o tablespace.o util.o version.o version_old_8_3.o = -L../../src/port -lpgport -L../../src/interfaces/libpq -lpq = -L../../src/port -O3 -fno-common -arch x86_64 -Wl,-dead_strip_dylibs = -lpgport -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -lm -o = pg_upgrade >> ld: duplicate symbol _scandir_file_pattern in controldata.o and = check.o >=20 > Oops. That global variable was not properly defined; not sure why = none > of the other compilers caught that bug. Anyway, the attached patch > should fix your problem, and will appear in 9.0 beta3. Thanks for the > report. >=20 > --=20 > Bruce Momjian http://momjian.us > EnterpriseDB http://enterprisedb.com >=20 > + None of us is going to be here forever. + > Index: contrib/pg_upgrade/pg_upgrade.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvsroot/pgsql/contrib/pg_upgrade/pg_upgrade.h,v > retrieving revision 1.7 > diff -c -c -r1.7 pg_upgrade.h > *** contrib/pg_upgrade/pg_upgrade.h 12 Jun 2010 17:45:28 -0000 = 1.7 > --- contrib/pg_upgrade/pg_upgrade.h 15 Jun 2010 02:01:48 -0000 > *************** > *** 237,243 **** > /* > * Global variables > */ > ! char scandir_file_pattern[MAXPGPATH]; >=20 >=20 > /* check.c */ > --- 237,243 ---- > /* > * Global variables > */ > ! extern char scandir_file_pattern[]; >=20 >=20 > /* check.c */ > Index: contrib/pg_upgrade/relfilenode.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvsroot/pgsql/contrib/pg_upgrade/relfilenode.c,v > retrieving revision 1.3 > diff -c -c -r1.3 relfilenode.c > *** contrib/pg_upgrade/relfilenode.c 13 May 2010 22:51:00 -0000 = 1.3 > --- contrib/pg_upgrade/relfilenode.c 15 Jun 2010 02:01:48 -0000 > *************** > *** 17,22 **** > --- 17,25 ---- > const char *oldnspname, const char = *oldrelname, > const char *newnspname, const char = *newrelname); >=20 > + /* used by scandir(), must be global */ > + char scandir_file_pattern[MAXPGPATH]; > + =20 > /* > * transfer_all_new_dbs() > * --Apple-Mail-45--221433311 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Sorry = for the late reply Josh, but apparently, Bruce already has a fix for the = issue - Thanks Bruce!!
Thanks a bunch, I'll put the patch in when I = get back home on Saturday.

.... if only my = commercial RDBMS provider had turn-around times like you guys = ....

best = regards,
-- 
chris ruprecht
specialist in obscure = details

On Jun 14, 2010, at 22:12 , Bruce Momjian wrote:

Chris = Ruprecht wrote:
I'm building the contrib = modules and get this:

gcc = -no-cpp-precomp -O3 -fno-common -arch x86_64 -Wall -Wmissing-prototypes = -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels = -fno-strict-aliasing -fwrapv check.o controldata.o dump.o exec.o file.o = function.o info.o option.o page.o pg_upgrade.o relfilenode.o server.o = tablespace.o util.o version.o version_old_8_3.o  -L../../src/port = -lpgport -L../../src/interfaces/libpq -lpq -L../../src/port -O3 = -fno-common -arch x86_64  -Wl,-dead_strip_dylibs  -lpgport = -lpam -lssl -lcrypto -lgssapi_krb5 -lz -lreadline -lm  -o = pg_upgrade
ld: duplicate = symbol _scandir_file_pattern in controldata.o and = check.o

Oops.  That global variable was not = properly defined;  not sure why none
of the other compilers = caught that bug.  Anyway, the attached patch
should fix your = problem, and will appear in 9.0 beta3.  Thanks for = the
report.

--
 Bruce Momjian  <bruce@momjian.us> =        http://momjian.us
 EnterpriseDB =             &n= bsp;           &nbs= p;   http://enterprisedb.com

=  + None of us is going to be here forever. +
Index: = contrib/pg_upgrade/pg_upgrade.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D
RCS file: = /cvsroot/pgsql/contrib/pg_upgrade/pg_upgrade.h,v
retrieving revision = 1.7
diff -c -c -r1.7 pg_upgrade.h
*** = contrib/pg_upgrade/pg_upgrade.h 12 Jun 2010 17:45:28 -0000 = 1.7
--- contrib/pg_upgrade/pg_upgrade.h 15 Jun = 2010 02:01:48 -0000
***************
*** 237,243 ****
=  /*
  * Global variables
  */
! = char = = scandir_file_pattern[MAXPGPATH];


 /* check.c = */
--- 237,243 ----
 /*
  * Global = variables
  */
! extern char = scandir_file_pattern[];


 /* check.c */
Index: = contrib/pg_upgrade/relfilenode.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D
RCS file: = /cvsroot/pgsql/contrib/pg_upgrade/relfilenode.c,v
retrieving revision = 1.3
diff -c -c -r1.3 relfilenode.c
*** = contrib/pg_upgrade/relfilenode.c 13 May 2010 22:51:00 -0000 = 1.3
--- contrib/pg_upgrade/relfilenode.c 15 Jun = 2010 02:01:48 -0000
***************
*** 17,22 ****
--- 17,25 = ----
  = = = = const char *oldnspname, const char *oldrelname,
  const = char *newnspname, const char *newrelname);

+ /* used by = scandir(), must be global */
+ char =     scandir_file_pattern[MAXPGPATH];
+
=  /*
  * transfer_all_new_dbs()
=   *

= --Apple-Mail-45--221433311--