Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id AB940B5DBE6 for ; Wed, 6 Jul 2011 14:00:14 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 73578-09 for ; Wed, 6 Jul 2011 17:00:08 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-iy0-f174.google.com (mail-iy0-f174.google.com [209.85.210.174]) by mail.postgresql.org (Postfix) with ESMTP id 795B6B5DBE2 for ; Wed, 6 Jul 2011 14:00:08 -0300 (ADT) Received: by iyb12 with SMTP id 12so105641iyb.19 for ; Wed, 06 Jul 2011 10:00:07 -0700 (PDT) Received: by 10.42.154.199 with SMTP id r7mr8576411icw.145.1309971607774; Wed, 06 Jul 2011 10:00:07 -0700 (PDT) Received: from [192.168.1.101] (c-69-181-249-16.hsd1.ca.comcast.net [69.181.249.16]) by mx.google.com with ESMTPS id a9sm6350449icy.6.2011.07.06.10.00.05 (version=SSLv3 cipher=OTHER); Wed, 06 Jul 2011 10:00:05 -0700 (PDT) Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG) From: Jeff Davis To: Tom Lane Cc: oleg@sai.msu.su, Denis de Bernardy , Teodor Sigaev , pgsql-bugs@postgresql.org In-Reply-To: <21432.1309888581@sss.pgh.pa.us> References: <4DF81BA0.3000601@archidevsys.co.nz> <743036.48052.qm@web112401.mail.gq1.yahoo.com> <366790.65150.qm@web112414.mail.gq1.yahoo.com> <1308428403.2597.66.camel@jdavis> <1308504190.2597.71.camel@jdavis> <21086.1309646333@sss.pgh.pa.us> <1309886656.3012.83.camel@jdavis> <21432.1309888581@sss.pgh.pa.us> Content-Type: multipart/mixed; boundary="=-m7htik6/gLOUtLE1MNfk" Date: Wed, 06 Jul 2011 10:00:11 -0700 Message-ID: <1309971611.3012.121.camel@jdavis> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201107/47 X-Sequence-Number: 30659 --=-m7htik6/gLOUtLE1MNfk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2011-07-05 at 13:56 -0400, Tom Lane wrote: > Yeah, I had been thinking along the same lines. It will require > duplicating the search loop, which is a bit annoying, but perhaps that > could be factored out as a subroutine. Patch attached. The logic in predtest.c was a little more complex, and I don't think we have a lot of test coverage in this area (and I didn't see an easy way to add many tests), so this will need some review. Regards, Jeff Davis --=-m7htik6/gLOUtLE1MNfk Content-Type: application/x-gzip; name="rowcmp2.patch.gz" Content-Disposition: attachment; filename="rowcmp2.patch.gz" Content-Transfer-Encoding: base64 H4sIAIiSFE4AA71Z23LbNhB9Vr5i/RRZJCOrjmV3nGQmddLG09T21Gn7qIElSERNERwCsqtm/O/d XYAXUZQvsVJNwkggeLCXg7NYptfrgeibfNy/EuNrmU76OrNqrv6VeX9hVdLPcjmx0thX4xdRFMHV I+f2Vj/0GwZ7g3CwNwQaAGOFVWO40jqBRBk7msv5lcxHxuYq637GEejReAgf/8ly6E2EXcx3j9kI B3QE+D16AStQVzaXckSGqLGw9E3raddBlKMhnOmJhN44EQsjQ4To0AccRC6nC3xSWVytBD9Xk85M 2pHDJydHOuviKBAqfg9pCjhE/rmGFdyLNVKplXkqkvtAEaNTfKBprl/SPzpK5QxdndSduNGIdpre iERhOOV5ll9QeE7EOJYnIkl+wrR2P1CgQeSzENAkGNNNNQnh1Mr5hWYrwS6yRF7YnMHpT2u6Dw4O w8HB4WuX8GdFj1K0Yu6vcgnXcnm8duNjavMlppa+jyT94DmE1+mMp3qRTo5f7BQDjWDxHUpP447O Q7qDn9LE5g3vFLwtAowwNTidTcVcJcuRqi/P5uAjU5EYyeOXNkdDZsuzBe0GFx7jxxo2NIfZgmKw trSfnqtZbO0yc+ucCHvCmwwoVpZ2Go9jfvER5fPa6ffoCj34WaGhOoe5uJYgHCuAwwtTHLaxMpAJ lYOegs5kTqExr9xuPTj4EXkwPCj265Yz6bxsj/92vGhl93CA7B4e7G+J3Z07utKFfEKLd9jiL2ia 1TAlw4VTNyi4BGOdWqFSlc7QdAkzdSPTut0M4YH+kjBfYL7bkWwsbAFn0DwbVzghSGQnreCh1DxL SEeVTjGE6UsLVxImEoVhrlI5eQXwPjE6ZJvKFXhxvwIIj2QWyoqrBMExaOWKYMV14VNpxUtgAscC zUfxEsTkhounU3okx8zm5GxiFaoU5tqOY4LzpiiJHgljFnMJt5IcAEwLiHQJOkVLtEcrHWI7Ej1D lylpCTtuYpURS+ievdWVnUAG0uhY57kcW4/Gv0ym0wl7VncX4/WFiGdivUgmcKvza2YjWeSXTZYl TGpwqyJla+74KPTpH7+XcRtcSpGP48ul4c1Ee33Qff/b+cX5xekHJOTV32jc6eQXaVnwu56qu07S 6xTEsFKcyDjKtSMQRWsDDUvSo3+xyAwoC8p4MAFv3tU9v0QWqilNiQXGDryqOkJiUIgsablU3dOG dK+oKCJ2fSSid6k/Whh4+xb2eLN9ZclsSDwi0C72v8qAsOgwIm7iU/MnaUu38ejuLgM62BbLbL5w hnU6v8tECiPreSlM3fVTHplDL/vFaWBTRisbHXylM6yMvFdxkywx9NIztxCql6bMB8Ycp69Vv0bM yvuORaz+w70j1MnD/VL9V5Wu0u17jkQlpWpHoRXva4cgZkHJYsrbTi1xHnq3RgNH9OcwvXh+hfBP onqB0M74gvKdWk3ZHmuflILy2LMpFavJIOI73t3hxckKMJk5gCiJKNMh3MaSlBsybZTFKkY1mhei 7853cqVWMXeK7NWOB9E7P6FyyH87Xp8aixs8E/H8+gYlMztU7zas4Grf41dw88sVCuLjOT6XdpGn 1fMB3OFf/IN8DOC5pZ8QHMxWCj8jbaPuM9Dzy37l3raKPoNtq+Yz2LNLvkdprfh0r7/SUuKPb2sq m21k2WQWHWazo8QJX2nSSntRScNxda/9UB60NkXBhqYoeKgpCtqboqCtKWpaXWuKgg1NUVBrinh/ buWMFfwP5be1bTk82g8HR3vbaso39l1O56JvFPxoTfAjkuPo8YK/NrVN8CMyM/KC377CZsFvX6Eh +H4FCkhT8AF8iPDKHSpQpJKEXq6xGmSzkZjjmooCCxIV3hqe1ncnq6M9SuVg4E5WvbU3efROzvTZ xH5iloa/tb7H2zSzjUGvfwhfHzJ7GAh/HuwVZzvM9SetvfXJYkY1BUsYsoxLQI70wSpApBPWipvZ rZrYuLvr6N0YHsWINKK92XoHI3z2x+fPx66a1l9w0WzcIo7WLIDIZ8sKvqqHOku1J3Wlbivv2EgE 3avIXq2QbJzBOmOKl2L9Ht2Nyg+QMsDJ+5NPHy+hGvYgHILWgA/398Ph8KjasGgsniDj0XSRjrku Vd4gBsXAR3NDFGrOrzu35g1ifSX6topjVIh2/R0arL1Gqi1AeTvltHXKNaoxJxh0Ld7W4IZwZ22/ GWivEUzjAFRWVvesk8tv1WmKjW+E6/b49kA8qjdYa4C5H/BIz2iAvXv4T1vvGz3Q+5YaVxTgDZWE I0BwPLnRRqx0EBH3vXTttLS80cMtb/SUlje6v+Vd7XYj7jVrCozydKZvwfAS9WMqEcpxhpSrq9CO vWNQ8AbWI4njQeDbR9rVw/1hODwcFBL4XbYfCs6jVM2hMhfClaNvTZvcGYabjI2kvr/ZqFHbgzy9 4S2p7REqggeO4IFjMv/XUCLTGdaJWpx2PZ8DykLgO+OH2EzzHhnGqs0lHjcUf3NkO3frbdy3qVjj fM+sCrZZ2h7FveAe6X+Oym9JnL/Hlv4PtTpy2xEdAAA= --=-m7htik6/gLOUtLE1MNfk--