Received: from maia.hub.org (maia-3.hub.org [200.46.204.243]) by mail.postgresql.org (Postfix) with ESMTP id 4BE1EB5DBCC for ; Wed, 6 Jul 2011 15:06:12 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.243]) (amavisd-maia, port 10024) with ESMTP id 32098-04 for ; Wed, 6 Jul 2011 18:06:06 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-iw0-f174.google.com (mail-iw0-f174.google.com [209.85.214.174]) by mail.postgresql.org (Postfix) with ESMTP id E821CB5D944 for ; Wed, 6 Jul 2011 15:06:05 -0300 (ADT) Received: by iwn6 with SMTP id 6so134330iwn.19 for ; Wed, 06 Jul 2011 11:06:05 -0700 (PDT) Received: by 10.42.161.73 with SMTP id s9mr333538icx.523.1309975565503; Wed, 06 Jul 2011 11:06:05 -0700 (PDT) Received: from [192.168.1.101] (c-69-181-249-16.hsd1.ca.comcast.net [69.181.249.16]) by mx.google.com with ESMTPS id a9sm6399078icy.6.2011.07.06.11.06.04 (version=SSLv3 cipher=OTHER); Wed, 06 Jul 2011 11:06:04 -0700 (PDT) Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG) From: Jeff Davis To: Tom Lane Cc: oleg@sai.msu.su, Denis de Bernardy , Teodor Sigaev , pgsql-bugs@postgresql.org In-Reply-To: <13404.1309973153@sss.pgh.pa.us> References: <4DF81BA0.3000601@archidevsys.co.nz> <743036.48052.qm@web112401.mail.gq1.yahoo.com> <366790.65150.qm@web112414.mail.gq1.yahoo.com> <1308428403.2597.66.camel@jdavis> <1308504190.2597.71.camel@jdavis> <21086.1309646333@sss.pgh.pa.us> <1309886656.3012.83.camel@jdavis> <21432.1309888581@sss.pgh.pa.us> <1309971611.3012.121.camel@jdavis> <13404.1309973153@sss.pgh.pa.us> Content-Type: text/plain; charset="UTF-8" Date: Wed, 06 Jul 2011 11:06:11 -0700 Message-ID: <1309975571.3012.141.camel@jdavis> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.9 tagged_above=-5 required=5 tests=BAYES_00=-1.9 X-Spam-Level: X-Archive-Number: 201107/50 X-Sequence-Number: 30662 On Wed, 2011-07-06 at 13:25 -0400, Tom Lane wrote: > Actually, I'd just been working on this myself. I think the cleanest > solution will be to get rid of the duplicative logic by making > predtest.c use get_op_btree_interpretation(). That will require > changing get_op_btree_interpretation() so it can return amoplefttype > and amoprighttype too, but given the small number of callers, an API > change for it doesn't seem like a problem. Sounds good to me. Regards, Jeff Davis