Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 4393F632805; Thu, 25 Mar 2010 14:45:55 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 47527-04; Thu, 25 Mar 2010 17:45:44 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 222CC632517; Thu, 25 Mar 2010 14:45:44 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id o2PHjOQc021053; Thu, 25 Mar 2010 13:45:24 -0400 (EDT) To: Josh Berkus cc: pgsql-hackers@postgresql.org, pgsql-testers@postgresql.org Subject: Re: Conditional trigger missing from pg_dump In-reply-to: <4BABA04E.6010603@agliodbs.com> References: <4BABA04E.6010603@agliodbs.com> Comments: In-reply-to Josh Berkus message dated "Thu, 25 Mar 2010 10:41:34 -0700" Date: Thu, 25 Mar 2010 13:45:24 -0400 Message-ID: <21052.1269539124@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 201003/1015 X-Sequence-Number: 159791 Josh Berkus writes: > It looks like pg_dump was never modified to include conditional > triggers. If you look in pg_dump.c, there's no provision to dump the > FOR UPDATE OF part of the trigger declaration. That proves nothing; it could be relying on server-side code to produce the declaration. > This was discovered by Dave Olszewski while testing conditional triggers. Please show a specific example of what you're worried about. regards, tom lane