pg.ddx.io  pgsql-testers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pg_upgrade and reg* system oid user types
8+ messages / 3 participants
[nested] [flat]

* pg_upgrade and reg* system oid user types
@ 2010-08-03 17:07  Glen Barber <glen.j.barber@gmail.com>
  0 siblings, 2 replies; 8+ messages in thread

From: Glen Barber @ 2010-08-03 17:07 UTC (permalink / raw)
  To: pgsql-testers

Hi,

I think it might be worth mentioning in the release notes (unless I've
missed it, of course) that, with the addition of
check_for_reg_data_type_usage(), pg_upgrade will error if it finds, for
example, tsearch data from pre-8.3 in user tables.

Otherwise, pg_upgrade has worked wonderfully for me - thanks again for
bringing it into contrib.

Best regards,

-- 
Glen Barber



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pg_upgrade and reg* system oid user types
@ 2010-08-03 18:18  Josh Berkus <josh@agliodbs.com>
  parent: Glen Barber <glen.j.barber@gmail.com>
  1 sibling, 1 reply; 8+ messages in thread

From: Josh Berkus @ 2010-08-03 18:18 UTC (permalink / raw)
  To: Glen Barber <glen.j.barber@gmail.com>; +Cc: pgsql-testers

On 8/3/10 10:07 AM, Glen Barber wrote:
> Hi,
> 
> I think it might be worth mentioning in the release notes (unless I've
> missed it, of course) that, with the addition of
> check_for_reg_data_type_usage(), pg_upgrade will error if it finds, for
> example, tsearch data from pre-8.3 in user tables.
> 
> Otherwise, pg_upgrade has worked wonderfully for me - thanks again for
> bringing it into contrib.

Good to hear.  Problem report forwarded to Bruce.

-- 
                                  -- Josh Berkus
                                     PostgreSQL Experts Inc.
                                     http://www.pgexperts.com



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pg_upgrade and reg* system oid user types
@ 2010-08-03 18:19  Bruce Momjian <bruce@momjian.us>
  parent: Josh Berkus <josh@agliodbs.com>
  0 siblings, 1 reply; 8+ messages in thread

From: Bruce Momjian @ 2010-08-03 18:19 UTC (permalink / raw)
  To: Josh Berkus <josh@agliodbs.com>; +Cc: Glen Barber <glen.j.barber@gmail.com>; pgsql-testers

Josh Berkus wrote:
> On 8/3/10 10:07 AM, Glen Barber wrote:
> > Hi,
> > 
> > I think it might be worth mentioning in the release notes (unless I've
> > missed it, of course) that, with the addition of
> > check_for_reg_data_type_usage(), pg_upgrade will error if it finds, for
> > example, tsearch data from pre-8.3 in user tables.
> > 
> > Otherwise, pg_upgrade has worked wonderfully for me - thanks again for
> > bringing it into contrib.
> 
> Good to hear.  Problem report forwarded to Bruce.

I was wondering if users were storing text search reg* data types in
their user tables.  Is this common?  Why only pre-8.3?

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pg_upgrade and reg* system oid user types
@ 2010-08-03 18:27  Bruce Momjian <bruce@momjian.us>
  parent: Glen Barber <glen.j.barber@gmail.com>
  1 sibling, 0 replies; 8+ messages in thread

From: Bruce Momjian @ 2010-08-03 18:27 UTC (permalink / raw)
  To: Glen Barber <glen.j.barber@gmail.com>; +Cc: pgsql-testers

Glen Barber wrote:
> Hi,
> 
> I think it might be worth mentioning in the release notes (unless I've
> missed it, of course) that, with the addition of
> check_for_reg_data_type_usage(), pg_upgrade will error if it finds, for
> example, tsearch data from pre-8.3 in user tables.

This is already mentioned in the pg_upgrade manual page.  Since this is
a new utility, and hence not changed from a preivous release, it would
not be appropriate to mention this restriction in the release notes,
unless it is a restriction we find to be common.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pg_upgrade and reg* system oid user types
@ 2010-08-03 18:29  Glen Barber <glen.j.barber@gmail.com>
  parent: Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 8+ messages in thread

From: Glen Barber @ 2010-08-03 18:29 UTC (permalink / raw)
  To: Bruce Momjian <bruce@momjian.us>; +Cc: Josh Berkus <josh@agliodbs.com>; pgsql-testers

On 8/3/10 2:19 PM, Bruce Momjian wrote:
> Josh Berkus wrote:
>> On 8/3/10 10:07 AM, Glen Barber wrote:
>>> Hi,
>>>
>>> I think it might be worth mentioning in the release notes (unless I've
>>> missed it, of course) that, with the addition of
>>> check_for_reg_data_type_usage(), pg_upgrade will error if it finds, for
>>> example, tsearch data from pre-8.3 in user tables.
>>>
>>> Otherwise, pg_upgrade has worked wonderfully for me - thanks again for
>>> bringing it into contrib.
>>
>> Good to hear.  Problem report forwarded to Bruce.
> 
> I was wondering if users were storing text search reg* data types in
> their user tables.  Is this common?  Why only pre-8.3?
> 

The database I am using in testing 9.0 is a development database which
mimics our production environment as closely as it can.  This particular
data has been through several PostgreSQL upgrades, beginning with 7.4,
if I remember correctly.  The reg* data types in user tables is from
before tsearch functionality was added to core.

Regards,

-- 
Glen Barber



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pg_upgrade and reg* system oid user types
@ 2010-08-03 18:36  Bruce Momjian <bruce@momjian.us>
  parent: Glen Barber <glen.j.barber@gmail.com>
  0 siblings, 1 reply; 8+ messages in thread

From: Bruce Momjian @ 2010-08-03 18:36 UTC (permalink / raw)
  To: Glen Barber <glen.j.barber@gmail.com>; +Cc: Josh Berkus <josh@agliodbs.com>; pgsql-testers

Glen Barber wrote:
> On 8/3/10 2:19 PM, Bruce Momjian wrote:
> > Josh Berkus wrote:
> >> On 8/3/10 10:07 AM, Glen Barber wrote:
> >>> Hi,
> >>>
> >>> I think it might be worth mentioning in the release notes (unless I've
> >>> missed it, of course) that, with the addition of
> >>> check_for_reg_data_type_usage(), pg_upgrade will error if it finds, for
> >>> example, tsearch data from pre-8.3 in user tables.
> >>>
> >>> Otherwise, pg_upgrade has worked wonderfully for me - thanks again for
> >>> bringing it into contrib.
> >>
> >> Good to hear.  Problem report forwarded to Bruce.
> > 
> > I was wondering if users were storing text search reg* data types in
> > their user tables.  Is this common?  Why only pre-8.3?
> > 
> 
> The database I am using in testing 9.0 is a development database which
> mimics our production environment as closely as it can.  This particular
> data has been through several PostgreSQL upgrades, beginning with 7.4,
> if I remember correctly.  The reg* data types in user tables is from
> before tsearch functionality was added to core.

OK, good to know.  I am hoping that isn't something that many people
have in their databases.  We can fix the reg* migration, but it is too
late for 9.0 and fixing it will require additional code in the backend
that we would prefer to avoid.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pg_upgrade and reg* system oid user types
@ 2010-08-03 18:46  Glen Barber <glen.j.barber@gmail.com>
  parent: Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 8+ messages in thread

From: Glen Barber @ 2010-08-03 18:46 UTC (permalink / raw)
  To: Bruce Momjian <bruce@momjian.us>; +Cc: Josh Berkus <josh@agliodbs.com>; pgsql-testers

On 8/3/10 2:36 PM, Bruce Momjian wrote:
>>> I was wondering if users were storing text search reg* data types in
>>> their user tables.  Is this common?  Why only pre-8.3?
>>>
>>
>> The database I am using in testing 9.0 is a development database which
>> mimics our production environment as closely as it can.  This particular
>> data has been through several PostgreSQL upgrades, beginning with 7.4,
>> if I remember correctly.  The reg* data types in user tables is from
>> before tsearch functionality was added to core.
> 
> OK, good to know.  I am hoping that isn't something that many people
> have in their databases.  We can fix the reg* migration, but it is too
> late for 9.0 and fixing it will require additional code in the backend
> that we would prefer to avoid.
> 

I wasn't sure if it would be common.  I was able to move forward with a
dump/restore for now; I'll remove the user tables in question and run it
through pg_upgrade again later this week.

Thanks for the feedback.

Regards,

-- 
Glen Barber



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pg_upgrade and reg* system oid user types
@ 2010-08-03 19:05  Bruce Momjian <bruce@momjian.us>
  parent: Glen Barber <glen.j.barber@gmail.com>
  0 siblings, 0 replies; 8+ messages in thread

From: Bruce Momjian @ 2010-08-03 19:05 UTC (permalink / raw)
  To: Glen Barber <glen.j.barber@gmail.com>; +Cc: Josh Berkus <josh@agliodbs.com>; pgsql-testers

Glen Barber wrote:
> On 8/3/10 2:36 PM, Bruce Momjian wrote:
> >>> I was wondering if users were storing text search reg* data types in
> >>> their user tables.  Is this common?  Why only pre-8.3?
> >>>
> >>
> >> The database I am using in testing 9.0 is a development database which
> >> mimics our production environment as closely as it can.  This particular
> >> data has been through several PostgreSQL upgrades, beginning with 7.4,
> >> if I remember correctly.  The reg* data types in user tables is from
> >> before tsearch functionality was added to core.
> > 
> > OK, good to know.  I am hoping that isn't something that many people
> > have in their databases.  We can fix the reg* migration, but it is too
> > late for 9.0 and fixing it will require additional code in the backend
> > that we would prefer to avoid.
> > 
> 
> I wasn't sure if it would be common.  I was able to move forward with a
> dump/restore for now; I'll remove the user tables in question and run it
> through pg_upgrade again later this week.

Yes, pg_upgrade should have recommended manual upgrade of tables using
reg* so you could still use pg_upgrade.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +



^ permalink  raw  reply  [nested|flat] 8+ messages in thread


end of thread, other threads:[~2010-08-03 19:05 UTC | newest]

Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-08-03 17:07 pg_upgrade and reg* system oid user types Glen Barber <glen.j.barber@gmail.com>
2010-08-03 18:18 ` Josh Berkus <josh@agliodbs.com>
2010-08-03 18:19   ` Bruce Momjian <bruce@momjian.us>
2010-08-03 18:29     ` Glen Barber <glen.j.barber@gmail.com>
2010-08-03 18:36       ` Bruce Momjian <bruce@momjian.us>
2010-08-03 18:46         ` Glen Barber <glen.j.barber@gmail.com>
2010-08-03 19:05           ` Bruce Momjian <bruce@momjian.us>
2010-08-03 18:27 ` Bruce Momjian <bruce@momjian.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox