Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbQRJ-0002v2-1F for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Jun 2019 14:10:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hbQRH-0004sz-UK for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Jun 2019 14:10:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbQRH-0004ss-IH for pgsql-hackers@lists.postgresql.org; Thu, 13 Jun 2019 14:10:51 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbQRD-0001yz-59 for pgsql-hackers@postgresql.org; Thu, 13 Jun 2019 14:10:50 +0000 Received: by mail-qt1-x843.google.com with SMTP id n11so20554773qtl.5 for ; Thu, 13 Jun 2019 07:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=JrsXv055o27s6S59MG5aBPWsAput6Gp9IcQcmYTX3fE=; b=QtEBRDHq/qADrkp6vCkxeC2iK/WkHNMn2s0PGa5wQ95fH1xxLMH6EdFRVkX2UrGSk0 CS1+q04BJfUeggLAxpJrZRIizlX/MmvFWTpEpZ+t7aBSb6GnzaFRtlxJP30O42yJj7IB KZiLyXwiypKdGzzEYETHQPC3FOnjlCQ2WkP27wEU0JavyvLGoQqoXuy2PoNBmp0M75k1 tyJY8epn6bX1hE0T9W6u2cD88AW5v0pDR3Z9ByV4JylQlsDAiJ4pNpolbe60K1b5/Qax LikKwrlJvx9MfkwFGqOy0avzZeLyS0IzcpsQDPPkAFhPRFMzpRVnqR9q3yMuFwa2atZ4 /+bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=JrsXv055o27s6S59MG5aBPWsAput6Gp9IcQcmYTX3fE=; b=RWCkpNzoz8fecNS65d/FIDsR1lFzJwd/rYdYj8oWCTw842Q3ZiV1XofTTOU8JWig1D KD4OUnfitCCs9ESZJ2WEfLqi8uwk5z02S3VFR1RCx6cpLX0eL7AYPBCrmrC2KAd9iWSO IooWogrK4DdI8ZWKBMANr8Wz/LZG77jKP12Sxw/bGll0CvN8byLVwwDxj5YrMOEl48Wz Pzop4WZ7XDmxy585r217mu7bqBknH7hIbC60P4cPWELEtPPSa5cq4qBj2mfvyyPhm2BU o9bisWGW5XhsivIcYLxXc6elmNsAZPCqaky/SPZ0khVjqTiLMhW0bSurt7QJw5PCefrQ 295A== X-Gm-Message-State: APjAAAX7ZLB6dgcvNEtsOE5IGUpOCq0p1hPQ6DOw+mf87wB920Wn4Qn3 Dj/gENWYXQU+2JCpn6gW3/4EDA== X-Google-Smtp-Source: APXvYqyArdf7Qm8hnke1cTn+eho1fJJDDEIIyrgRfgtKXePEhY7o7uC1gXpQ0z4mEFVMIUmGzPo9UQ== X-Received: by 2002:aed:2667:: with SMTP id z94mr77812995qtc.2.1560435046364; Thu, 13 Jun 2019 07:10:46 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id o33sm1593142qtk.67.2019.06.13.07.10.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 07:10:45 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 8524B120B96; Thu, 13 Jun 2019 10:10:43 -0400 (-04) Date: Thu, 13 Jun 2019 10:10:43 -0400 From: Alvaro Herrera To: Michael Paquier Cc: Stephen Amell , pgsql-hackers@postgresql.org Subject: Re: Quitting the thes Message-ID: <20190613141043.GA488@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190613064443.GF1643@paquier.xyz> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Jun-13, Michael Paquier wrote: > On Wed, Jun 12, 2019 at 02:45:27PM -0400, Alvaro Herrera wrote: > > Some grepping found a bit more; patch attached. > > Indeed. There were much more. I just got to look with stuff like > that: > find . -name "*.c" | xargs egrep "(\b[a-zA-Z]+) \1\b" This is what I used: git grep '\<\([a-z_ ]\+\)\> \<\1\>' > But I did not find any more spots. Indentation is incorrect in > test_integerset.c. Indeed ... fixed. Thanks for looking, -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services