Feedback-ID: ie0a040ee:Fastmail
Message-ID: <201dfced-2690-441d-a7c4-ff8bbd76bb69@eisentraut.org>
Date: Fri, 7 Feb 2025 10:14:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Japanese message translation file for postgres (pg_basebackup)
To: "Naoki Yotsunaga (Fujitsu)" <yotsunaga.naoki@fujitsu.com>,
 "'pgsql-translators@lists.postgresql.org'"
 <pgsql-translators@lists.postgresql.org>
References: 
 <TY3PR01MB10943E055C01AD2CF3A00D134F6132@TY3PR01MB10943.jpnprd01.prod.outlook.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <TY3PR01MB10943E055C01AD2CF3A00D134F6132@TY3PR01MB10943.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/201dfced-2690-441d-a7c4-ff8bbd76bb69%40eisentraut.org>
Precedence: bulk

On 09.01.25 04:42, Naoki Yotsunaga (Fujitsu) wrote:
> It is about the following Japanese translation.
> https://github.com/postgres/postgres/blob/3f482940dbcbd15834a67894f4d9efdf5ceb7e16/src/bin/pg_basebackup/po/ja.po#L1151
> msgid "renaming backup_manifest.tmp to backup_manifest"
> msgstr "backup_manifest.tmp の名前を backup_manifest に変更してください"
> 
> This sentence would lead one to mistakenly believe that the user needs to rename the backup_manifest.tmp file to backup_manifest.
> "してください" is a word that instructs you to do something.
> Therefore, it would be better to modify it as follows.
> - backup_manifest.tmp の名前を backup_manifest に変更してください
> + backup_manifest.tmp の名前を backup_manifest に変更しています

Fixed in all live branches.  Thanks!