From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Pg Hackers <pgsql-hackers@postgresql.org>,
        pgsql-translators@postgresql.org
Subject: Re: [HACKERS] translatable string fixes
In-reply-to: <20170523001557.bq2hbq7hxyvyw62q@alvherre.pgsql>
References: <20170523001557.bq2hbq7hxyvyw62q@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Mon, 22 May 2017 20:15:57 -0400"
Date: Wed, 24 May 2017 14:13:52 -0400
Message-ID: <2712.1495649632@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-translators-owner@postgresql.org

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> It took me a very long time to figure out how to translate these 9.6-new
> strings in the AM validate routines:
> msgid "gin operator family \"%s\" contains support procedure %s with cross-type registration"
> ...
> Maybe we can use this phrasing:
> "gin operator family %s contains support procedure %s registered with different left and right types"

OK with me, or maybe better "support procedure %s with different left and
right input types".  I doubt "registered" adds much.

> The other complaint I have about this one and also other amvalidate
> functions is the hardcoded AM name, so it's actually one string per AM,
> which is annoying (a total of twenty-something messages which are
> actually only four or five different ones).  Ignoring the second part of
> the phrase now, we could use this:
>   "operator family %s of access method %s contains support procedure %s with cross-type registration"

If that seems better to the actual translators, it's OK with me. It's
not real clear where is the boundary between combining near-duplicate
messages and assembling messages at runtime.

			regards, tom lane


-- 
Sent via pgsql-translators mailing list (pgsql-translators@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-translators