pg.ddx.io pgsql-translators@postgresql.org mailing list archive
help / color / mirror / Atom feedpg_upgrade translation
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2017-07-14 837255cc81 pg_upgrade i18n: Fix "%s server/cluster" wording
* pg_upgrade translation
@ 2017-05-23 00:28 Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 2 replies; 4+ messages in thread
From: Alvaro Herrera @ 2017-05-23 00:28 UTC (permalink / raw)
To: Pg Hackers <pgsql-hackers@postgresql.org>; pgsql-translators
Translatability was turned on for pg_upgrade on pg10, but it needs some
work. The choices are we fix it now, or we revert the addition of NLS
there and we do it for PG11.
I think the ugliest one is to change the messages about "the %s server",
which are about a dozen -- things like:
msgid "pg_ctl failed to start the %s server, or connection failed\n"
where the %s is either "new" or "old".
These need be to be split in two messages, and I think I'd replace the
"old" with "source" and "new" with "target". Something like this:
inline patch 1: src/bin/pg_upgrade/server.c (+7/-0 lines) download inline-1.patch
*** a/src/bin/pg_upgrade/server.c
--- b/src/bin/pg_upgrade/server.c
***************
*** 285,293 **** start_postmaster(ClusterInfo *cluster, bool throw_error)
PQerrorMessage(conn));
if (conn)
PQfinish(conn);
! pg_fatal("could not connect to %s postmaster started with the command:\n"
! "%s\n",
! CLUSTER_NAME(cluster), cmd);
}
PQfinish(conn);
--- 285,297 ----
PQerrorMessage(conn));
if (conn)
PQfinish(conn);
! if (cluster == &old_cluster)
! pg_fatal("could not connect to source postmaster started with the command:\n"
! "%s\n", cmd);
! else
! pg_fatal("could not connect to target postmaster started with the command:\n"
! "%s\n", cmd);
!
}
PQfinish(conn);
* Re: [HACKERS] pg_upgrade translation
@ 2017-05-24 19:51 Robert Haas <robertmhaas@gmail.com>
parent: Alvaro Herrera <alvherre@2ndquadrant.com>
1 sibling, 1 reply; 4+ messages in thread
From: Robert Haas @ 2017-05-24 19:51 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: Pg Hackers <pgsql-hackers@postgresql.org>; pgsql-translators
On Mon, May 22, 2017 at 8:28 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Translatability was turned on for pg_upgrade on pg10, but it needs some
> work. The choices are we fix it now, or we revert the addition of NLS
> there and we do it for PG11.
>
> I think the ugliest one is to change the messages about "the %s server",
> which are about a dozen -- things like:
> msgid "pg_ctl failed to start the %s server, or connection failed\n"
> where the %s is either "new" or "old".
>
> These need be to be split in two messages, and I think I'd replace the
> "old" with "source" and "new" with "target".
>
> Aye or nay?
Aye.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-translators mailing list (pgsql-translators@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-translators
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [HACKERS] pg_upgrade translation
@ 2017-05-24 19:54 Tom Lane <tgl@sss.pgh.pa.us>
parent: Robert Haas <robertmhaas@gmail.com>
0 siblings, 0 replies; 4+ messages in thread
From: Tom Lane @ 2017-05-24 19:54 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: Alvaro Herrera <alvherre@2ndquadrant.com>; Pg Hackers <pgsql-hackers@postgresql.org>; pgsql-translators
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, May 22, 2017 at 8:28 PM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
>> Translatability was turned on for pg_upgrade on pg10, but it needs some
>> work. The choices are we fix it now, or we revert the addition of NLS
>> there and we do it for PG11.
>> Aye or nay?
> Aye.
+1
regards, tom lane
--
Sent via pgsql-translators mailing list (pgsql-translators@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-translators
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pg_upgrade translation
@ 2017-05-28 18:39 Alvaro Herrera <alvherre@2ndquadrant.com>
parent: Alvaro Herrera <alvherre@2ndquadrant.com>
1 sibling, 0 replies; 4+ messages in thread
From: Alvaro Herrera @ 2017-05-28 18:39 UTC (permalink / raw)
To: Pg Hackers <pgsql-hackers@postgresql.org>; pgsql-translators
Alvaro Herrera wrote:
> Translatability was turned on for pg_upgrade on pg10, but it needs some
> work. The choices are we fix it now, or we revert the addition of NLS
> there and we do it for PG11.
Here are two patches to fix the messages, replacing "new" with "target"
and "old" with "source". I was going to do just the first one
initially, but I figured that the output would become wildly
inconsistent if I stopped at that point.
Now we still have one inconsistency left: the command-line options
--old-bindir --new-datadir etc all contain the words "new" and "old".
Same with a bunch of environment variables. I think the real solution
is that we should change those to --source-bindir and --target-datadir
respectively (and the other ones continue to work for backwards
compatibility), but then maybe leave them alone.
I'll continue fixing things.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
0001-pg_upgrade-Fix-s-server-cluster-wording.patch (text/plain, 0B) download
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2017-05-28 18:39 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-05-23 00:28 pg_upgrade translation Alvaro Herrera <alvherre@2ndquadrant.com>
2017-05-24 19:51 ` Robert Haas <robertmhaas@gmail.com>
2017-05-24 19:54 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-05-28 18:39 ` Alvaro Herrera <alvherre@2ndquadrant.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox