Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgFvo-0001Y1-Fa for pgsql-translators@arkaria.postgresql.org; Fri, 11 Aug 2017 19:49:16 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dgFvo-0006bR-2G for pgsql-translators@arkaria.postgresql.org; Fri, 11 Aug 2017 19:49:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dgFvn-0006bI-S9 for pgsql-translators@postgresql.org; Fri, 11 Aug 2017 19:49:15 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dgFvj-00076J-KW for pgsql-translators@postgresql.org; Fri, 11 Aug 2017 19:49:14 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 89E1B20AC6; Fri, 11 Aug 2017 15:49:09 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Fri, 11 Aug 2017 15:49:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=/Ev6zVf/eLCJl7UZKwMJNUQ95oBQk3gJiLrBpuORt68=; b=AI90Jvpj ITZ/poIzHDe4R+v63+6j0+pnAME9sjvdNZ4fk1SnOR5XJ7DHykXBdXle1tUL16yZ AFdMaVLSBAfasIg5uZ/7IgzAnC82M8Bq6bMHSGTdWRmSa3hvKXqVhXW+bR0Et5nd HLNWsF0V7n/bmgK7DKIeS5gjOMZfaZw13ABrjywIPBVgd9COatPXI5ylU5omwcbC H30XG679i3XshEv6sE+ZsMztJlACty2NZK+Vwy45pIlI6dGITf59xAoH26pSfKKr bdYU/Pn33CmEbFh1q1aYCJJtz0ds9IPizJW22JzABY7GpZX3WV5Y5HCJG3y8xtTI EdVUditq0sAtQQ== X-ME-Sender: X-Sasl-enc: TgYipvPaXiSVenzbMRqTVUNWOwo3b6xb4jacBQ/bnNWX 1502480949 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 3627D240A4; Fri, 11 Aug 2017 15:49:09 -0400 (EDT) Subject: Re: Wrong original string in pg_upgrade? To: =?UTF-8?Q?Dennis_Bj=c3=b6rklund?= , pgsql-translators@postgresql.org References: From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <4f4c2abc-8587-7c10-6e44-017d55e202f3@2ndquadrant.com> Date: Fri, 11 Aug 2017 15:49:07 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-translators Precedence: bulk Sender: pgsql-translators-owner@postgresql.org On 8/7/17 01:42, Dennis Björklund wrote: > In pg_upgrade we have the string > > "Checking for reg* system OID user data types" > > see: > https://github.com/postgres/postgres/blob/master/src/bin/pg_upgrade/check.c#L897 > > Shouldn't it say something like: > > "Checking for reg* system OID used in user tables" Yes, I think that is better. Fixed. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-translators mailing list (pgsql-translators@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-translators