Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRIUQ-0007mX-JV for pgsql-hackers@arkaria.postgresql.org; Sun, 03 Nov 2019 16:12:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iRIUO-00066s-A9 for pgsql-hackers@arkaria.postgresql.org; Sun, 03 Nov 2019 16:12:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRIUO-00066j-1V for pgsql-hackers@lists.postgresql.org; Sun, 03 Nov 2019 16:12:28 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRIUH-0001c9-1s for pgsql-hackers@lists.postgresql.org; Sun, 03 Nov 2019 16:12:27 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xA3GCFbV005528; Sun, 3 Nov 2019 11:12:15 -0500 From: Tom Lane To: kerbrose khaled cc: "pgsql-hackers@lists.postgresql.org" Subject: Re: updating unaccent.rules for Arabic letters In-reply-to: References: Comments: In-reply-to kerbrose khaled message dated "Sun, 03 Nov 2019 06:05:25 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5526.1572797535.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 03 Nov 2019 11:12:15 -0500 Message-ID: <5527.1572797535@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk kerbrose khaled writes: > I would like to update unaccent.rules file to support Arabic letters. so= could someone help me or tell me how could I add such contribution. I att= ached the file including the modifications, only the last 4 lines. Hi! I've got no objection to including Arabic in the set of covered languages, but handing us a new unaccent.rules file isn't the way to do it, because that's a generated file. The adjacent script generate_unaccent_rules.py generates it from the official Unicode source data (see comments in that script). What we need, ultimately, is a patch to that script so it will emit these additional translations. Past commits that might be useful sources of inspiration include https://git.postgresql.org/gitweb/?p=3Dpostgresql.git&a=3Dcommitdiff&h=3D4= 56e3718e7b72efe4d2639437fcbca2e4ad83099 https://git.postgresql.org/gitweb/?p=3Dpostgresql.git&a=3Dcommitdiff&h=3D5= e8d670c313531c0dca245943fb84c94a477ddc4 https://git.postgresql.org/gitweb/?p=3Dpostgresql.git&a=3Dcommitdiff&h=3De= c0a69e49bf41a37b5c2d6f6be66d8abae00ee05 If you're not good with Python, maybe you could just explain to us how to recognize these characters from Unicode character properties. regards, tom lane