MIME-Version: 1.0
References: 
 <CAHut+PtkMHzMk3+kDYSNzf8+=K30zuC3EzLRZxnAt58DhWQeRQ@mail.gmail.com>
 <F98636D2-B4C4-4CE8-8EA6-E29CFA544CB4@yesql.se>
In-Reply-To: <F98636D2-B4C4-4CE8-8EA6-E29CFA544CB4@yesql.se>
From: Peter Smith <smithpb2250@gmail.com>
Date: Wed, 15 Nov 2023 12:20:10 +1100
Message-ID: 
 <CAHut+Pv_2QtyS9DwKoLVp7PgL7S02JqyQWmXxXTRjwaeSYQiKg@mail.gmail.com>
Subject: Fwd: Some deleted GUCs are still referred to
To: pgsql-translators@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAHut%2BPv_2QtyS9DwKoLVp7PgL7S02JqyQWmXxXTRjwaeSYQiKg%40mail.gmail.com>
Precedence: bulk

FYI.

=3D=3D=3D=3D=3D=3D
Kind Regards,
Peter Smith.
Fujitsu Australia

---------- Forwarded message ---------
From: Daniel Gustafsson <daniel@yesql.se>
Date: Thu, Nov 9, 2023 at 8:12=E2=80=AFPM
Subject: Re: Some deleted GUCs are still referred to
To: Peter Smith <smithpb2250@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>


> On 9 Nov 2023, at 00:51, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi,
>
> I happened to notice that some GUC names "max_fsm_pages" and
> "max_fsm_relations" are still mentioned in these translation files
> (from the REL_16_1 source zip)
>
> src\backend\po\fr.po
> src\backend\po\tr.po
>
> ~~
>
> Should those be removed?

These mentions are only in comments and not in actual translations, so I do=
n't
think they risk causing any issues.

 $ git grep max_fsm_ |cut -d":" -f 2 |grep -v "^#" | wc -l
       0

I don't know enough about the translation workflow to know how these commen=
ts
are handled, sending this to pgsql-translators@ might be a better way to re=
ach
the authors working on this.

> There was a commit [1] that said these all traces of those GUCs had
> been eliminated.

Translations are managed in an external repo and synced with the main repo =
at
intervals, so such a commit couldn't have updated the master translation wo=
rk
files anyways.

--
Daniel Gustafsson