Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\))
Subject: Re: Some deleted GUCs are still referred to
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: 
 <CAHut+PtkMHzMk3+kDYSNzf8+=K30zuC3EzLRZxnAt58DhWQeRQ@mail.gmail.com>
Date: Thu, 9 Nov 2023 10:12:03 +0100
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <F98636D2-B4C4-4CE8-8EA6-E29CFA544CB4@yesql.se>
References: 
 <CAHut+PtkMHzMk3+kDYSNzf8+=K30zuC3EzLRZxnAt58DhWQeRQ@mail.gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/F98636D2-B4C4-4CE8-8EA6-E29CFA544CB4%40yesql.se>
Precedence: bulk

> On 9 Nov 2023, at 00:51, Peter Smith <smithpb2250@gmail.com> wrote:
>=20
> Hi,
>=20
> I happened to notice that some GUC names "max_fsm_pages" and
> "max_fsm_relations" are still mentioned in these translation files
> (from the REL_16_1 source zip)
>=20
> src\backend\po\fr.po
> src\backend\po\tr.po
>=20
> ~~
>=20
> Should those be removed?

These mentions are only in comments and not in actual translations, so I =
don't
think they risk causing any issues.

 $ git grep max_fsm_ |cut -d":" -f 2 |grep -v "^#" | wc -l
       0

I don't know enough about the translation workflow to know how these =
comments
are handled, sending this to pgsql-translators@ might be a better way to =
reach
the authors working on this.

> There was a commit [1] that said these all traces of those GUCs had
> been eliminated.

Translations are managed in an external repo and synced with the main =
repo at
intervals, so such a commit couldn't have updated the master translation =
work
files anyways.

--
Daniel Gustafsson