public inbox for [email protected]  

help / color / mirror / Atom feed

From: Célestin Matte <[email protected]>
To: [email protected]
Subject: Re: [PATCHES] pgarchives: merge schema.sql into Django's model
Date: Tue, 21 Feb 2023 17:49:05 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Hello,

I sent these patches over a year ago. Can they be reviewed?
Patches I sent earlier were rejected because a full merge of the database creation process was a better approach. This series of patches does exactly that.

On 07/05/2022 11:32, Célestin Matte wrote:
> Hi there,
> 
> Gentle reminder that this patch has not been reviewed and may have been forgotten
> 
> On 03/02/2022 14:30, Célestin Matte wrote:
>> As discussed in previous threads before [1, 2], database creations file are currently split between the Django model and a SQL file. Discrepancy in the database's definition exists between them. As a consequence, the database cannot be created easily.
>> This series of patches merge schema.sql into Django's model, and adds specific postgres components that cannot be handled by Django's ORM using RunSQL() in a migration file.
>>
>> Please also note that I integrated several other patches to avoid multiple migration files:
>> - I allowed message.parentid to be null, as discussed in [1]. This can cause Internal Server Errors in views.py, which are fixed by the second patch.
>> - I used BinaryFields for bytea columns (message.rawtxt and attachments.attachment), which seems to be the way to integrate bytea into Django
>>
>> It may be a good opportunity to remove all mentions of pg_dict, pg_stop and associated file. I'm not sure of the consequences of this. According to [2], these are the remains of an aborted idea.
>> Also, what does tsparer bring? Can the installation of pgarchives be simplified by replacing it with pg_catalog.english?
>>
>>
>> [1]: https://www.postgresql.org/message-id/CABUevEyFpYPEHh0AAyTAsgymRKOOVA1SY_pDHPCbBQQ9BawfTA%40mail.gma...
>> [2]: https://www.postgresql.org/message-id/CABUevEy_i1xAKscMv4KZ0%3DbE8050bBcQfWaNyjwZZBofZx7JgQ%40mail.g...
> 
> 

-- 
Célestin Matte

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCHES] pgarchives: merge schema.sql into Django's model
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox