Message-ID: <0c0f0cff-513a-e2e5-8ff7-a8f1463e364d@cmatte.me>
Date: Wed, 19 Jan 2022 15:30:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py
Content-Language: en-US
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
References: <a06e51d0-a7ec-741a-8d93-780011b53cec@cmatte.me>
 <0d7d2e12-bdf9-8b7b-4b90-8380eeef7c16@postgresql.org>
 <CABUevEw+gtEVa1sq0H5FMXuYnm1EXU6mxaqLaYn42tindmCAyQ@mail.gmail.com>
From: =?UTF-8?Q?C=c3=a9lestin_Matte?= <celestin.matte@cmatte.me>
In-Reply-To: 
 <CABUevEw+gtEVa1sq0H5FMXuYnm1EXU6mxaqLaYn42tindmCAyQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/0c0f0cff-513a-e2e5-8ff7-a8f1463e364d%40cmatte.me>
Precedence: bulk

Hi,

I'm reviewing the patches I sent a few months ago and this short one seems to have been left mid-discussion.

> I think having a default like in this patch is better. Otherwise it could randomly connect to a database with the same name as the user for example, which might actually happen in dev scenarios. So if we want it empty we'd also need to add code to check if it's set or not before trying to use it - seems easier to set the default and have it fail :)

I guess it's OK as-is, then?

-- 
Célestin Matte