X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (av.hub.org [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id CB455DBB54 for ; Fri, 18 Nov 2005 20:59:12 -0400 (AST) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 14660-09 for ; Sat, 19 Nov 2005 00:59:15 +0000 (GMT) X-Greylist: from auto-whitelisted by SQLgrey- Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr1.postgresql.org (Postfix) with ESMTP id 57BC9DBB4E for ; Fri, 18 Nov 2005 20:59:08 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id jAJ0x5Qg013653; Fri, 18 Nov 2005 19:59:05 -0500 (EST) To: Alvaro Herrera cc: Patches Subject: Re: DROP OWNED again In-reply-to: <20051118195430.GA26861@surnet.cl> References: <20051118195430.GA26861@surnet.cl> Comments: In-reply-to Alvaro Herrera message dated "Fri, 18 Nov 2005 16:54:30 -0300" Date: Fri, 18 Nov 2005 19:59:04 -0500 Message-ID: <13652.1132361944@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, score=0.005 required=5 tests=[AWL=0.005] X-Spam-Score: 0.005 X-Spam-Level: X-Archive-Number: 200511/121 X-Sequence-Number: 17870 Alvaro Herrera writes: > /* > ! * Called to execute the utility commands GRANT and REVOKE. > ! * > ! * stmt may be a complete GrantStmt created by the parser, or it may be > ! * missing the "objects" list and the "grantees" list. In this case, > ! * they are taken from the second and third parameters, respectively. > */ > void > ! ExecuteGrantStmt(GrantStmt *stmt, Oid object, Oid grantee) This seems like a really ugly API. What's so hard about expecting the caller to construct a valid GrantStmt? (I get the impression from a quick scan of the code that the comment is a long way from telling the truth about what's really happening, either.) > + static void AlterConversionOwner_int(Relation rel, Oid conversionOid, > + Oid newOwnerId); If these are supposed to mean "AlterConversionOwner_internal", please spell them that way. Sitting beside "AlterConversionOwner_oid", it sure looks like the "int" is meant to be read as "integer". regards, tom lane