From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200408191635.i7JGZaT13179@candle.pha.pa.us>
Subject: Re: [BUGS] 8.0.0beta1: -lpthread missing
In-Reply-To: <41245A6B.3010705@betrusted.com>
To: =?ISO-8859-1?Q?Martin_M=FCnstermann?= <mmuenstermann@betrusted.com>
Date: Thu, 19 Aug 2004 12:35:36 -0400 (EDT)
Cc: Robert Treat <xzilla@users.sourceforge.net>,
	PostgreSQL-patches <pgsql-patches@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UNKNOWN-8BIT

Martin Münstermann wrote:
> Bruce Momjian wrote:
> > OK, I got it working now.  Seems the code needed more help to loop than
> > I though, and of course trying to change it as little as possible caused
> > me to miss that.
> > 
> > The attached, applied patch properly aggregates the thread flags.  The
> > bad news is that on my platform that needs _no_ thread flags or
> > libraries I have:
> > 
> > 	PTHREAD_CFLAGS          =3D   -Kthread -kthread -pthread -pthreads
> > 			-D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS
> > 	PTHREAD_LIBS            =3D
> > 
> > I assume those are just ignored for portability so I assume we are OK.
> 
> Current CVS is working for Solaris, too.
> Compiles and libthread.so is used at runtime. :-)
> 
> PTHREAD_CFLAGS          =  -pthreads   -Kthread -kthread -pthread 
> -pthreads  -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS
> PTHREAD_LIBS            =  -lpthread            -lpthread
> 
> The -Kthread -kthread is not needed here, but is included because gcc 
> 3.2 does not treat them as error, but just dumps out "gcc: unrecognized 
> option `-kthread'".

Yep, same here.  I am hoping we come up with a cleaner solution someday. :-)

But I am thrilled to have this threading all automated now.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073