public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bruce Momjian <[email protected]>
To: PostgreSQL www <[email protected]>
Subject: Re: [pgsql-patches] subject tag
Date: Fri, 19 Jan 2007 11:18:19 -0500 (EST)
Message-ID: <[email protected]> (raw)
Why does the patches list now have a lowercase tag, "[pgsql-patches]"?
The jobs list is also lowercase.
---------------------------------------------------------------------------
----- Forwarded message from FAST PostgreSQL -----
X-Greylist: from auto-whitelisted by SQLgrey-1.7.4
X-SEF-Processed: 5_0_0_816__2007_01_19_17_44_12
Date: Sat, 20 Jan 2007 04:44:51 +1100
From: FAST PostgreSQL <[email protected]>
Reply-To: FAST PostgreSQL <[email protected]>
To: Neil Conway <[email protected]>
cc: [email protected]
Message-ID: <12753.10921169188931.fast.fujitsu.com.au@MHS>
In-Reply-To: <[email protected]>
References: <12753.10901169180733.fast.fujitsu.com.au@MHS>
References: <[email protected]>
Subject: Re: [pgsql-patches] pg_get_domaindef
x-scalix-Hops: 1
Organization: FAST
X-Mailer: KMail [version 1.3.2]
Content-Disposition: inline
X-Virus-Scanned: by amavisd-new at mail1.fujitsu.com.au
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Mailing-List: pgsql-patches
List-Archive: <http://archives.postgresql.org/pgsql-patches;
List-Help: <mailto:[email protected]?body=help>
List-Id: <pgsql-patches.postgresql.org>
List-Owner: <mailto:[email protected]>
List-Post: <mailto:[email protected]>
List-Subscribe: <mailto:[email protected]?body=sub%20pgsql-patches>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-patches>
Precedence: bulk
Sender: [email protected]
On Fri, 19 Jan 2007 17:02, Neil Conway wrote:
> On Sat, 2007-01-20 at 02:28 +1100, FAST PostgreSQL wrote:
> > Attached is a small patch that implements the pg_get_domaindef(oid)
> > function.
>
> A few minor comments:
>
> - don't use C++-style comments
OK. Can do.
>
> - why does this code append a "-" to the output when SPI_processed != 1,
> rather than erroring out?
get_ruledef() does the same. As the user gets a '-' in that case when a
non-existent oid is given, I just wanted to be consistent. Maybe a wrong
idea ?
>
> - you probably want to elog(ERROR) if typeTuple is invalid:
Of course.
> + if (typnotnull || constraint != NULL)
> + {
> + if ( ( (contype != NULL) && (strcmp(contype,
> "c") != 0) ) || typnotnull )
> + {
> + appendStringInfo(&buf, "CONSTRAINT ");
> + }
> + if (typnotnull)
> + {
> + appendStringInfo(&buf, "NOT NULL ");
> + }
> + }
> + if (constraint != NULL)
> + {
> + appendStringInfo(&buf,
> quote_identifier(constraint));
> + }
>
> This logic seems pretty awkward. Perhaps simpler would be a check for
> typnotnull (and then appending "CONSTRAINT NOT NULL"), and then handling
> the non-typnotnull branch separately.
Yeah agree.
>
> -Neil
Rgds,
Arul Shaji
This is an email from Fujitsu Australia Software Technology Pty Ltd, ABN 27 003 693 481. It is confidential to the ordinary user of the email address to which it was addressed and may contain copyright and/or legally privileged information. No one else may read, print, store, copy or forward all or any of it or its attachments. If you receive this email in error, please return to sender. Thank you.
If you do not wish to receive commercial email messages from Fujitsu Australia Software Technology Pty Ltd, please email [email protected]
---------------------------(end of broadcast)---------------------------
TIP 6: explain analyze is your friend
----- End of forwarded message from FAST PostgreSQL -----
--
Bruce Momjian [email protected]
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [pgsql-patches] subject tag
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox