Received: from localhost (maia-1.hub.org [200.46.204.191])
	by postgresql.org (Postfix) with ESMTP id B1EC49FB312
	for <pgsql-hackers-postgresql.org@postgresql.org>;
	Sat,  5 May 2007 11:33:29 -0300 (ADT)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.191]) (amavisd-maia, port 10024)
	with ESMTP id 87502-06 for
	<pgsql-hackers-postgresql.org@postgresql.org>;
	Sat,  5 May 2007 11:33:24 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.4
Received: from momjian.us (momjian.us [70.90.9.53])
	by postgresql.org (Postfix) with ESMTP id E607E9FB322
	for <pgsql-hackers@postgresql.org>;
	Sat,  5 May 2007 11:33:24 -0300 (ADT)
Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id
 l45EXNj20626;
	Sat, 5 May 2007 10:33:23 -0400 (EDT)
From: Bruce Momjian <bruce@momjian.us>
Message-Id: <200705051433.l45EXNj20626@momjian.us>
Subject: Re: New idea for patch tracking
In-Reply-To: <463C93A6.4040401@sun.com>
To: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Date: Sat, 5 May 2007 10:33:23 -0400 (EDT)
CC: PostgreSQL-development <pgsql-hackers@postgresql.org>
X-Mailer: ELM [version 2.4ME+ PL123]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200705/262
X-Sequence-Number: 102864


OK, item modified to:

	<li>Passes all regression tests, and if needed, adds new
	ones</li>

---------------------------------------------------------------------------

Zdenek Kotala wrote:
> I would like to add one point:
> 
> Bruce Momjian wrote:
> 
> > 
> > Patch committers check several things before applying a patch:
> > 
> > 1)  Follows the SQL standard or community agreed-upon behavior
> > 2)  Style merges seamlessly into the surrounding code
> > 3)  Written as simply and efficiently as possible
> > 4)  Uses the available PostgreSQL subsystems properly
> > 5)  Contains sufficient comments
> > 6)  Contains code that works on all supported operating systems
> > 7)  Has proper documentation
> > 8)  Passes all regression tests
> 
>    8.5) Contains regression test(s) which covered performed changes
> 
> > 9)  Behaves as expected, even under unusual cirumstances
> > 10)  Contains no reliability risks
> > 11)  Does not overly complicate the source code
> > 12)  If performance-related, it should have a measureable performance benefit
> > 13)  Is of sufficient usefulness to the average PostgreSQL user
> > 14)  Follows existing PostgreSQL coding standards
> > 
> 
> 
> 	Zdenek

-- 
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +