Date: Thu, 27 Mar 2008 11:43:24 +0100
From: Magnus Hagander <magnus@hagander.net>
To: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, PostgreSQL www
	<pgsql-www@postgresql.org>
Subject: Re: Patch to make some strings available to
 translations
Message-ID: <20080327114324.71ed6bd5@mha-laptop>
In-Reply-To: <47EADA2E.5010608@lelarge.info>
References: <47DAF7E3.8070502@lelarge.info> <47DD4BAA.5000402@hagander.net>
	<47DD9F5C.1060101@lelarge.info> <47E0B5CD.9030504@lelarge.info>
	<47E18498.4060609@lelarge.info> <47E18CDB.60303@hagander.net>
	<47E18DFA.5030003@lelarge.info> <47E52413.1030407@lelarge.info>
	<47E52489.7030608@lelarge.info>
	<20080322205914.GF13206@alvh.no-ip.org>
	<47E57F91.9010809@lelarge.info>
	<20080326223645.6ea671b1@mha-laptop>
	<47EADA2E.5010608@lelarge.info>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Guillaume Lelarge wrote:
> Magnus Hagander a =C3=A9crit :
> > On Sat, 22 Mar 2008 22:52:17 +0100
> > Guillaume Lelarge <guillaume@lelarge.info> wrote:
> >=20
> >> Alvaro Herrera a =C3=A9crit :
> >>> Guillaume Lelarge wrote:
> >>>
> >>>>> I guess I was wrong. You'll find a patch attached that
> >>>>> implements a func_image function via a call to
> >>>>> setCallbackFunction.
> >>>>>
> >>>>> I can also send a complete patch (the previous one which adds =20
> >>>>> translation to some texts, and this patch).
> >>> Suggestion: check if the image exists in the translated version,
> >>> serve the english version if not.  That way you only need to
> >>> produce alternate images for those that need translation.
> >>>
> >> Damn, forgot about this one. You're right. Patch version 2
> >> attached.
> >=20
> > Applied, thanks.
> >=20
>=20
> Thanks a lot.
>=20
> > Can you please re-send the patch with the other translation stuff?
> > I've managed to mess up the different versions of it so I'm no
> > longer sure I'm working off the correct one :-(
> >=20
>=20
> Here it is. Thanks for looking at it.
>=20
>=20
> --=20
> Guillaume.
>   http://www.postgresqlfr.org
>   http://dalibo.com


This patch no longer applies :-(

The change to pgpage.php was in your other patch.

There's a whole bunch of conflicts in index.html.

Also, the page as generated does not come out as XHTML valid. This is
because you changed it to use ' instead of " for some attributes, and
when there is ' in the text (The world's most advanced...), the HTML is
broken. I'd really like a way to keep the "s on the tags instead of ',
so please see if you can find some way for that :-)

//Magnus