Date: Tue, 13 Mar 2018 13:01:05 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Magnus Hagander <magnus@hagander.net>,
	PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Subject: Re: Bogus reports from coverage.postgresql.org
Message-ID: <20180313170105.GC2416@tamriel.snowman.net>
References: <d0eec0fd-bf3b-55da-f5de-4fa1c00ce400@2ndquadrant.com>
 <CABUevEyydszbZJPF6iyjU45C+Kx4YSCa+KDZJkXNdjiGbE0Ojg@mail.gmail.com>
 <30195.1520790475@sss.pgh.pa.us>
 <30669.1520791101@sss.pgh.pa.us>
 <CABUevEx5Q0YEPrsdUL75BB0z+Ns3m7eX=x3oRwttjHRJ0HeQRw@mail.gmail.com>
 <31446.1520791925@sss.pgh.pa.us>
 <1594.1520795000@sss.pgh.pa.us>
 <2633.1520796277@sss.pgh.pa.us>
 <bc1608e2-41ad-4c07-f939-e165944eb163@2ndquadrant.com>
 <13148.1520798486@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bih4Kc99TlSoOJvo"
Content-Disposition: inline
In-Reply-To: <13148.1520798486@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--bih4Kc99TlSoOJvo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > I tried it on Debian stable with gcc 6.3.0 and couldn't reproduce it.
> > cc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
>=20
> Oh ... *that's* interesting.  Are we sure this is the version in use
> on coverage.postgresql.org?

Yes, it's the same, but this isn't a gcov issue, I don't think.

> Also, I just finished searching in vain for any plausibly-matching
> bug at https://gcc.gnu.org/bugzilla/.  I did find a few reports
> suggesting that gcov could misbehave with nondefault build options
> such as LTO.  And "gcov -a" has also had issues.  So maybe we ought
> to have a look at exactly what coverage.postgresql.org's build
> recipe is.

Running gcov on the box itself in the source dir shows the same results
which you got:

---
        -:  487:                        }
    #####:  488:                        break;
        -:  489:        }
        -:  490:
        -:  491:        /* can't get here */
    #####:  492:        elog(ERROR, "predicate_classify returned a bogus va=
lue");
        -:  493:        return false;
        -:  494:}
---

Which seems to indicate that this actually is some kind of lcov bug.
That makes more sense too since lcov is 1.13 on coverage.p.o, but you
used 1.10 and said you didn't see an issue.  Not sure if you have access
to 1.13 easily, but if so, could be useful to see if you're seeing the
same behavior under 1.13 where the gcov output is correct but lcov
output isn't.

Thanks!

Stephen

--bih4Kc99TlSoOJvo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJaqAPRAAoJEO1sijiDR2RVqcIQAJXuAs2zPZo47Wmv12RPfvoN
O5I2hBSMOBhQBNMiNr2u1rAt2y0wLZbTpVbRsQHmUK+wJ9KR3coWWdkIeAR/6/Kq
U5hwg1aviCW/JxktL02b4OlOKh6uEB/yisADwN3lAlprwOXXh0peXJV3yuK1GrQz
1C5XeuFtDYTcHjwutgmLoluDLa/5G4etmZ0bqcTHseeTkkmaMeYJl8CeWmQFdBXT
w2z0oWhypkdh1noqiFTghgHbX9KBrbgiaicmg+PgwhHl7zPKFFkOe/+cnbGOdKxr
dvKkim4Hw2E0a7YmV5sGpd8Hm/UJ0b2vU6Fiw4/u2zrWxODjVZDnkEjvLq7NfPfT
X2ftMYaRl2wU9jEigteWLe2qyna0I2WKH1cxm0oCu2m2+izm8EjvCiEmFW71TCo4
ANsFSw+Nvaz2UxRAfOLYH5J2/go1dpTxccNVe9CecP3nswRWH2zhv4ZEeLcAZfXI
lFgya4rsOIIaeg8RVK8y6s19ipfMZ7iDZTzr6jrruP58yqTsah4YkyyBJ9O9Q3f4
CWQl6959gPmZ5x2NQEhBb/WzJrRrzm3YDlXibxtXmhQF2sakvXlgTbVIjf2CKwaq
zxOC8n+MmO9OKqF4tM+lj4aPPpQQEqpxqqhQvCQgTwD8eBqmoYlkf2e5c0QVW82w
e1GU3zLsULfMzEpSDRfB
=RYnf
-----END PGP SIGNATURE-----

--bih4Kc99TlSoOJvo--