Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fcXWc-0001ps-6s
	for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Jul 2018 14:52:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fcXWX-0005wP-TA
	for pgsql-hackers@arkaria.postgresql.org; Mon, 09 Jul 2018 14:52:21 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <shackle@fetter.org>)
	id 1fcXWX-0005wI-MV
	for pgsql-hackers@lists.postgresql.org; Mon, 09 Jul 2018 14:52:21 +0000
Received: from xvm-110-146.dc2.ghst.net ([46.226.110.146] helo=fetter.org)
	by magus.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <shackle@fetter.org>)
	id 1fcXWP-0004Xq-Nh
	for pgsql-hackers@lists.postgresql.org; Mon, 09 Jul 2018 14:52:21 +0000
Received: by fetter.org (Postfix, from userid 1001)
	id C651741CB6; Mon,  9 Jul 2018 16:52:11 +0200 (CEST)
Date: Mon, 9 Jul 2018 16:52:11 +0200
From: David Fetter <david@fetter.org>
To: Bruce Momjian <bruce@momjian.us>
Cc: Andres Freund <andres@anarazel.de>,
	Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Postgres 11 release notes
Message-ID: <20180709145211.GO22932@fetter.org>
References: <20180511150852.GA18510@momjian.us>
 <99778850-e1fb-9ed5-c6e1-09dddbf0303d@lab.ntt.co.jp>
 <20180709052815.lh55klasauvhb4ii@alap3.anarazel.de>
 <20180709143630.GA19710@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180709143630.GA19710@momjian.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On Mon, Jul 09, 2018 at 10:36:30AM -0400, Bruce Momjian wrote:
> On Sun, Jul  8, 2018 at 10:28:15PM -0700, Andres Freund wrote:
> > On 2018-07-09 14:18:14 +0900, Tatsuro Yamada wrote:
> > > Hi Bruce,
> > > 
> > > > I expect a torrent of feedback.;-)
> > > 
> > > Could you add this fix to the release note because this change affects
> > > an extension developer using the hook function.
> > > It would be better to know the change by reading the release note, not compilation error.
> > > 
> > > <!--
> > > 2017-01-11 [4d41b2e09] Add QueryEnvironment to ExplainOneQuery_hook's parameter list.
> > > -->
> > >        <para>
> > >         Add QueryEnvironment to ExplainOneQuery_hook's parameter list
> > >         (Tatsuro Yamada, Thomas Munro)
> > >        </para>
> > > 
> > > Discussion: https://postgr.es/m/890e8dd9-c1c7-a422-6892-874f5eaee048@lab.ntt.co.jp
> > > 
> > > I guess "E.1.3.11. Source Code" or "E.1.3.12. Additional Modules" sections are
> > > suitable for putting the message in the release note.
> > 
> > We adapt plenty of functions signatures without listing them
> > individually in the release notes. I don't think randomly selecting one
> > relatively uncommonly used hook is a good way to attack that.
> 
> Agreed.  Ideally we would have a wiki page that lists _all_ the hooks,
> and what release they were added.

If we're talking about ideals, all our public APIs including the hooks
should be in the official documentation and have man pages.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate