Date: Thu, 30 May 2019 15:16:50 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Magnus Hagander <magnus@hagander.net>,
	PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Subject: Re: Bogus reports from coverage.postgresql.org
Message-ID: <20190530191650.GA24909@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20190530191130.GA24528@alvherre.pgsql>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On 2019-May-30, Alvaro Herrera wrote:

> On 2018-Mar-12, Peter Eisentraut wrote:
> 
> > On 3/11/18 16:05, Tom Lane wrote:
> > > It might be worth blowing away ccache's cache just to see if it's cached
> > > anything bogus.
> > 
> > --enable-coverage disables ccache, so that's not going to be it.
> 
> (Ref. src/Makefile.global.in lines 484ff setting CCACHE_DISABLE=1)
> 
> Why does it do that?  Now that ccache is about 5 years less buggy than
> it was when you wrote this, can we get rid of this behavior?

I think I found the answer in this commit:
https://github.com/ccache/ccache/commit/02d3f078bd2495b8db2264ae0b2c692b4c5ba1bd
"Add support for coverage (compiling for gcov)"
committed for ccache 3.2.2.

So I think we could remove that stuff now ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services