Feedback-ID: ia2694551:Fastmail
Date: Wed, 15 Mar 2023 09:41:27 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "Karl O. Pinc" <kop@karlpinc.com>
Cc: Greg Stark <stark@mit.edu>,
	"Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>,
	w^3 <pgsql-www@lists.postgresql.org>
Subject: Re: Doc: Rework contrib appendix -- informative titles, tweaked
 sentences
Message-ID: <20230315084127.r6do3gtfph6t7p2c@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230314162919.7342db4d@slate.karlpinc.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230315084127.r6do3gtfph6t7p2c%40alvherre.pgsql>
Precedence: bulk

On 2023-Mar-14, Karl O. Pinc wrote:

> On Tue, 14 Mar 2023 13:57:57 -0400
> Greg Stark <stark@mit.edu> wrote:
> 
> > Sorry, having read the whole thread I think it's clear. The source
> > tree patch was committed by Alvaro H in
> > a7e584a7d68a9a2bcc7efaf442262771f9044248 and then Katz pushed the
> > pgweb change. So I gather this is resolved now and I've marked it
> > committed by Alvaro.

Actually, the 0001 patch hadn't been fully committed yet ... I had only
added the CSS tweaks.  I have now pushed the addition of the tables to
the SGML sources, with minor tag changes: I found that with the
<simplelist> outside of any <para>, the list was too close to the next
paragraph, which looked a bit ugly.  I put the list inside the <para>
that explains what the list is.  It looks good with PDF, website-HTML
and plain-HTML rendering now; didn't look at other output formats.
So, the CF entry being marked committed is now correct as far as I'm
concerned.

> There remains an un-committed patch from this thread/commitfest
> entry:

> diff --git a/doc/src/sgml/stylesheet-fo.xsl b/doc/src/sgml/stylesheet-fo.xsl
> index 0c4dff92c4..68a46f9e24 100644
> --- a/doc/src/sgml/stylesheet-fo.xsl
> +++ b/doc/src/sgml/stylesheet-fo.xsl

> +<!-- Every sect1 in the contrib appendix gets a page break -->
> +<xsl:template match="id('contrib')/sect1">
> +  <fo:block break-after='page'/>
> +  <xsl:apply-imports/>
> +</xsl:template>

Yeah, I think this one achieves what I wanted and isn't a maintenance
burden, but I would like to hear from other CSS people.  I guess I could
just commit it and see what complaints I get (probably none).

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
“Cuando no hay humildad las personas se degradan” (A. Christie)