public inbox for [email protected]
help / color / mirror / Atom feedbad style for SECURITY DEFINER
9+ messages / 4 participants
[nested] [flat]
* bad style for SECURITY DEFINER
@ 2021-12-13 00:17 Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Re: bad style for SECURITY DEFINER Peter Eisentraut <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Justin Pryzby @ 2021-12-13 00:17 UTC (permalink / raw)
To: [email protected]
The title of this section looks poor in the first two web browsers I tried.
https://www.postgresql.org/docs/current/sql-createfunction.html#id-1.9.3.67.10.2
| Writing SECURITY DEFINER Functions Safely
It looks like it may be the only <literal> tag within a <refsect1>.
The PDF looks fine.
--
Justin
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: bad style for SECURITY DEFINER
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
@ 2021-12-13 10:35 ` Peter Eisentraut <[email protected]>
2021-12-13 13:11 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Peter Eisentraut @ 2021-12-13 10:35 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; [email protected]
On 13.12.21 01:17, Justin Pryzby wrote:
> The title of this section looks poor in the first two web browsers I tried.
> https://www.postgresql.org/docs/current/sql-createfunction.html#id-1.9.3.67.10.2
> | Writing SECURITY DEFINER Functions Safely
This appears to be a web site styling issue. It looks more reasonable
when I use the default style.
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: bad style for SECURITY DEFINER
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Re: bad style for SECURITY DEFINER Peter Eisentraut <[email protected]>
@ 2021-12-13 13:11 ` Daniel Gustafsson <[email protected]>
2021-12-13 14:01 ` Re: bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Gustafsson @ 2021-12-13 13:11 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Justin Pryzby <[email protected]>; [email protected]
> On 13 Dec 2021, at 11:35, Peter Eisentraut <[email protected]> wrote:
>
> On 13.12.21 01:17, Justin Pryzby wrote:
>> The title of this section looks poor in the first two web browsers I tried.
>> https://www.postgresql.org/docs/current/sql-createfunction.html#id-1.9.3.67.10.2
>> | Writing SECURITY DEFINER Functions Safely
>
> This appears to be a web site styling issue. It looks more reasonable when I use the default style.
Agreed, the <code> class should not override the font size of the <h2> and
should have a different margin than when rendered elsewhere. It's not entirely
clear to me why we set a font-size at all, I can't see which case that's
supposed to be fixing but my CSS is really rusty so I'm sure to be missing
something. However, this should be moved to -www where it can be dealt with.
--
Daniel Gustafsson https://vmware.com/
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: bad style for SECURITY DEFINER
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Re: bad style for SECURITY DEFINER Peter Eisentraut <[email protected]>
2021-12-13 13:11 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
@ 2021-12-13 14:01 ` Justin Pryzby <[email protected]>
2021-12-13 21:33 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Justin Pryzby @ 2021-12-13 14:01 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; pgsql-www
On Mon, Dec 13, 2021 at 02:11:24PM +0100, Daniel Gustafsson wrote:
> > On 13 Dec 2021, at 11:35, Peter Eisentraut <[email protected]> wrote:
> >
> > On 13.12.21 01:17, Justin Pryzby wrote:
> >> The title of this section looks poor in the first two web browsers I tried.
> >> https://www.postgresql.org/docs/current/sql-createfunction.html#id-1.9.3.67.10.2
> >> | Writing SECURITY DEFINER Functions Safely
> >
> > This appears to be a web site styling issue. It looks more reasonable when I use the default style.
>
> Agreed, the <code> class should not override the font size of the <h2> and
> should have a different margin than when rendered elsewhere. It's not entirely
> clear to me why we set a font-size at all, I can't see which case that's
> supposed to be fixing but my CSS is really rusty so I'm sure to be missing
> something. However, this should be moved to -www where it can be dealt with.
So done.
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: bad style for SECURITY DEFINER
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Re: bad style for SECURITY DEFINER Peter Eisentraut <[email protected]>
2021-12-13 13:11 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
2021-12-13 14:01 ` Re: bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
@ 2021-12-13 21:33 ` Jonathan S. Katz <[email protected]>
2021-12-13 21:43 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Jonathan S. Katz @ 2021-12-13 21:33 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; Daniel Gustafsson <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; pgsql-www
On 12/13/21 9:01 AM, Justin Pryzby wrote:
> On Mon, Dec 13, 2021 at 02:11:24PM +0100, Daniel Gustafsson wrote:
>>> On 13 Dec 2021, at 11:35, Peter Eisentraut <[email protected]> wrote:
>>>
>>> On 13.12.21 01:17, Justin Pryzby wrote:
>>>> The title of this section looks poor in the first two web browsers I tried.
>>>> https://www.postgresql.org/docs/current/sql-createfunction.html#id-1.9.3.67.10.2
>>>> | Writing SECURITY DEFINER Functions Safely
The below seems to do the trick. Tested in Chrome, FF, and Safari.
Screenshot attached.
If no objections I'll push the patch tomorrow.
Thanks,
Jonathan
diff --git a/media/css/main.css b/media/css/main.css
index d97da4d..955f612 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -877,6 +877,10 @@ code,
font-size: inherit !important;
}
+#docContent h2 code {
+ margin: 0.5em;
+}
+
#docContent .NAVHEADER table th,
#docContent .navheader table th {
text-align: center;
Attachments:
[image/png] Screen Shot 2021-12-13 at 4.32.24 PM.png (25.9K, 2-Screen%20Shot%202021-12-13%20at%204.32.24%20PM.png)
download | view image
[application/pgp-signature] OpenPGP_signature (840B, 3-OpenPGP_signature)
download
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: bad style for SECURITY DEFINER
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Re: bad style for SECURITY DEFINER Peter Eisentraut <[email protected]>
2021-12-13 13:11 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
2021-12-13 14:01 ` Re: bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 21:33 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
@ 2021-12-13 21:43 ` Daniel Gustafsson <[email protected]>
2021-12-13 22:14 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Gustafsson @ 2021-12-13 21:43 UTC (permalink / raw)
To: Jonathan S. Katz <[email protected]>; +Cc: Justin Pryzby <[email protected]>; Peter Eisentraut <[email protected]>; pgsql-www
> On 13 Dec 2021, at 22:33, Jonathan S. Katz <[email protected]> wrote:
>
> On 12/13/21 9:01 AM, Justin Pryzby wrote:
>> On Mon, Dec 13, 2021 at 02:11:24PM +0100, Daniel Gustafsson wrote:
>>>> On 13 Dec 2021, at 11:35, Peter Eisentraut <[email protected]> wrote:
>>>>
>>>> On 13.12.21 01:17, Justin Pryzby wrote:
>>>>> The title of this section looks poor in the first two web browsers I tried.
>>>>> https://www.postgresql.org/docs/current/sql-createfunction.html#id-1.9.3.67.10.2
>>>>> | Writing SECURITY DEFINER Functions Safely
>
> The below seems to do the trick. Tested in Chrome, FF, and Safari. Screenshot attached.
>
> If no objections I'll push the patch tomorrow.
The margin issue looks right but I think the font-size should match the rest of
the title.
--
Daniel Gustafsson https://vmware.com/
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: bad style for SECURITY DEFINER
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Re: bad style for SECURITY DEFINER Peter Eisentraut <[email protected]>
2021-12-13 13:11 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
2021-12-13 14:01 ` Re: bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 21:33 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
2021-12-13 21:43 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
@ 2021-12-13 22:14 ` Jonathan S. Katz <[email protected]>
2021-12-14 09:27 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Jonathan S. Katz @ 2021-12-13 22:14 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: Justin Pryzby <[email protected]>; Peter Eisentraut <[email protected]>; pgsql-www
On 12/13/21 4:43 PM, Daniel Gustafsson wrote:
> The margin issue looks right but I think the font-size should match the rest of
> the title.
Please see attached and below for revision.
I'm not thrilled about the !important override that's needed to deal
with another !important, but I don't want to try to unweave the
!important nest given the lack of overall cases of a code block nested
within h2 title tags.
Jonathan
diff --git a/media/css/main.css b/media/css/main.css
index d97da4d..e7b1455 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -877,6 +877,14 @@ code,
font-size: inherit !important;
}
+#docContent h2 code {
+ font-size: inherit !important;
+ margin-bottom: 0em;
+ margin-left: 0.5em;
+ margin-right: 0.5em;
+ margin-top: 0em;
+}
+
#docContent .NAVHEADER table th,
#docContent .navheader table th {
text-align: center;
Attachments:
[image/png] Screen Shot 2021-12-13 at 5.12.29 PM.png (61.5K, 2-Screen%20Shot%202021-12-13%20at%205.12.29%20PM.png)
download | view image
[application/pgp-signature] OpenPGP_signature (840B, 3-OpenPGP_signature)
download
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: bad style for SECURITY DEFINER
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Re: bad style for SECURITY DEFINER Peter Eisentraut <[email protected]>
2021-12-13 13:11 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
2021-12-13 14:01 ` Re: bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 21:33 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
2021-12-13 21:43 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
2021-12-13 22:14 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
@ 2021-12-14 09:27 ` Daniel Gustafsson <[email protected]>
2021-12-14 19:07 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Gustafsson @ 2021-12-14 09:27 UTC (permalink / raw)
To: Jonathan S. Katz <[email protected]>; +Cc: Justin Pryzby <[email protected]>; Peter Eisentraut <[email protected]>; pgsql-www
> On 13 Dec 2021, at 23:14, Jonathan S. Katz <[email protected]> wrote:
>
> On 12/13/21 4:43 PM, Daniel Gustafsson wrote:
>
>> The margin issue looks right but I think the font-size should match the rest of
>> the title.
>
> Please see attached and below for revision.
I think this looks much better, and it matches how the PDF's are rendered.
> I'm not thrilled about the !important override that's needed to deal with another !important, but I don't want to try to unweave the !important nest given the lack of overall cases of a code block nested within h2 title tags.
Agreed on both counts.
--
Daniel Gustafsson https://vmware.com/
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: bad style for SECURITY DEFINER
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Re: bad style for SECURITY DEFINER Peter Eisentraut <[email protected]>
2021-12-13 13:11 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
2021-12-13 14:01 ` Re: bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 21:33 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
2021-12-13 21:43 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
2021-12-13 22:14 ` Re: bad style for SECURITY DEFINER Jonathan S. Katz <[email protected]>
2021-12-14 09:27 ` Re: bad style for SECURITY DEFINER Daniel Gustafsson <[email protected]>
@ 2021-12-14 19:07 ` Jonathan S. Katz <[email protected]>
0 siblings, 0 replies; 9+ messages in thread
From: Jonathan S. Katz @ 2021-12-14 19:07 UTC (permalink / raw)
To: Daniel Gustafsson <[email protected]>; +Cc: Justin Pryzby <[email protected]>; Peter Eisentraut <[email protected]>; pgsql-www
On 12/14/21 4:27 AM, Daniel Gustafsson wrote:
>> On 13 Dec 2021, at 23:14, Jonathan S. Katz <[email protected]> wrote:
>>
>> On 12/13/21 4:43 PM, Daniel Gustafsson wrote:
>>
>>> The margin issue looks right but I think the font-size should match the rest of
>>> the title.
>>
>> Please see attached and below for revision.
>
> I think this looks much better, and it matches how the PDF's are rendered.
>
>> I'm not thrilled about the !important override that's needed to deal with another !important, but I don't want to try to unweave the !important nest given the lack of overall cases of a code block nested within h2 title tags.
>
> Agreed on both counts.
Thanks for the review, and thanks to Justin for the report. I've pushed
this up. It should be available on the next cache refresh.
Thanks,
Jonathan
Attachments:
[application/pgp-signature] OpenPGP_signature (840B, 2-OpenPGP_signature)
download
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2021-12-14 19:07 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-12-13 00:17 bad style for SECURITY DEFINER Justin Pryzby <[email protected]>
2021-12-13 10:35 ` Peter Eisentraut <[email protected]>
2021-12-13 13:11 ` Daniel Gustafsson <[email protected]>
2021-12-13 14:01 ` Justin Pryzby <[email protected]>
2021-12-13 21:33 ` Jonathan S. Katz <[email protected]>
2021-12-13 21:43 ` Daniel Gustafsson <[email protected]>
2021-12-13 22:14 ` Jonathan S. Katz <[email protected]>
2021-12-14 09:27 ` Daniel Gustafsson <[email protected]>
2021-12-14 19:07 ` Jonathan S. Katz <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox