X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (av.hub.org [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id E8D79DA820 for ; Mon, 21 Nov 2005 16:04:00 -0400 (AST) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 24955-02 for ; Mon, 21 Nov 2005 20:04:00 +0000 (GMT) X-Greylist: domain auto-whitelisted by SQLgrey- Received: from svr2.postgresql.org (svr2.postgresql.org [65.19.161.25]) by svr1.postgresql.org (Postfix) with ESMTP id 9C199DA662 for ; Mon, 21 Nov 2005 16:03:56 -0400 (AST) Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by svr2.postgresql.org (Postfix) with ESMTP id 66F2DF0D9D for ; Mon, 21 Nov 2005 16:57:45 +0000 (GMT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.1/8.13.1) with ESMTP id jALGveLk002508; Mon, 21 Nov 2005 11:57:40 -0500 (EST) To: Alvaro Herrera Cc: Patches Subject: Re: aclchk.c refactor In-reply-to: <20051121163441.GA19278@surnet.cl> References: <20051118195430.GA26861@surnet.cl> <13652.1132361944@sss.pgh.pa.us> <20051119225514.GA16420@surnet.cl> <20051121133308.GB11527@surnet.cl> <20051121151652.GA12273@surnet.cl> <20051121163441.GA19278@surnet.cl> Comments: In-reply-to Alvaro Herrera message dated "Mon, 21 Nov 2005 13:34:41 -0300" Date: Mon, 21 Nov 2005 11:57:40 -0500 Message-ID: <2507.1132592260@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, score=0.004 required=5 tests=[AWL=0.004] X-Spam-Score: 0.004 X-Spam-Level: X-Archive-Number: 200511/134 X-Sequence-Number: 17883 Alvaro Herrera writes: > Now I noticed that there are multiple functions pg_class_aclmask, > pg_database_aclmask, pg_language_aclmask, etc. Is there any objection > to making the exported routine expose the object type as an AclKind > parameter instead of having one function for each object type? How about "in addition to" instead of "instead"? I see no reason to impose extra notation and a level of indirection on the places that know perfectly well which object type they are dealing with. regards, tom lane