From: Daniel Gustafsson <daniel@yesql.se>
Message-Id: <37BBDD19-A021-44D6-8108-B5D079900A2B@yesql.se>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_E8233BB5-4BB5-4A63-9A55-F687E687B5F7"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\))
Subject: Re: Copy script button cleanup
Date: Wed, 3 Dec 2025 14:26:51 +0100
In-Reply-To: 
 <CABUevExmHVYwddKvFUWkjY8Ev-xAE2p0-mP0wJqJDs1bazMn7A@mail.gmail.com>
Cc: Dave Page <dpage@pgadmin.org>,
 PostgreSQL WWW <pgsql-www@lists.postgresql.org>
To: Magnus Hagander <magnus@hagander.net>
References: 
 <CA+OCxoxH75C4Q79bOfxpwXJtgZxjgTtR1xa+cWL0NVBNnT_OyA@mail.gmail.com>
 <CABUevExmHVYwddKvFUWkjY8Ev-xAE2p0-mP0wJqJDs1bazMn7A@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/37BBDD19-A021-44D6-8108-B5D079900A2B%40yesql.se>
Precedence: bulk


--Apple-Mail=_E8233BB5-4BB5-4A63-9A55-F687E687B5F7
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

> On 2 Dec 2025, at 15:41, Magnus Hagander <magnus@hagander.net> wrote:
> On Tue, 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org =
<mailto:dpage@pgadmin.org>> wrote:
>> The Copy Script buttons on the Linux package installation pages look =
horrific. See before.png.
>>=20
>> The attached patch makes them look much nicer, with proper sizing and =
an icon based button. On click, it briefly changes to a green checkmark =
to show confirmation. See the after screenshots.
>>=20
>> I'll apply this in a couple of days if there are no objections.
>=20
> LGTM in general and certainly is a lot prettier.

+1, it looks much better!

--
Daniel Gustafsson


--Apple-Mail=_E8233BB5-4BB5-4A63-9A55-F687E687B5F7
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=us-ascii

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dus-ascii"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: =
after-white-space;"><div><blockquote type=3D"cite"><div>On 2 Dec 2025, =
at 15:41, Magnus Hagander &lt;magnus@hagander.net&gt; =
wrote:</div><div><div dir=3D"ltr"><div class=3D"gmail_quote =
gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, 2 =
Dec 2025 at 12:30, Dave Page &lt;<a =
href=3D"mailto:dpage@pgadmin.org">dpage@pgadmin.org</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px =
0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>The Copy Script =
buttons on the Linux package installation pages look horrific. See =
before.png.</div><div><br></div><div>The attached patch makes them look =
much nicer, with proper sizing and an icon based button. On click, it =
briefly changes to a green checkmark to show confirmation. See the after =
screenshots.</div><div><br></div><div>I'll apply this in a couple of =
days if there are no =
objections.</div></div></blockquote><div><br></div><div>LGTM in general =
and certainly is a lot =
prettier.</div></div></div></div></blockquote><div><br></div><div>+1, it =
looks much better!</div></div><br><div>
<div>--<br>Daniel Gustafsson</div>

</div>
<br></body></html>=

--Apple-Mail=_E8233BB5-4BB5-4A63-9A55-F687E687B5F7--