DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=Kd7/tUupp/8UlVWF8P+bjoIqC/itcV1sRZC8rDozGk+zaLt3ZEH6O1cj2IuRRMC9XNGVMpHMWf8YU5d1lhosKyP5F4r1hOiVpSe+wOKRLbHe+haoQf7HrZmAGLwQ0NKkjjCltj3qn8/ItSBgK3RG3BveBKJB5jlPRlvooj8wE4I=
Message-ID: <37ed240d0805070725oa5778b1q9ed77349fdcc24f4@mail.gmail.com>
Date: Thu, 8 May 2008 00:25:16 +1000
From: "Brendan Jurd" <direvus@gmail.com>
To: "Tom Lane" <tgl@sss.pgh.pa.us>
Subject: Re: Posting to hackers and patches lists
Cc: "Bruce Momjian" <bruce@momjian.us>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
In-Reply-To: <6229.1210169873@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200805071408.m47E8Qt22784@momjian.us>
	<6229.1210169873@sss.pgh.pa.us>

On Thu, May 8, 2008 at 12:17 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Bruce Momjian <bruce@momjian.us> writes:
>  > I think it would be helpful for us to provide an infrastructure where
>  > people who don't run their own servers to store their patches at a
>  > stable URL where they can keep updating the content.  I did that with
>  > the psql wrap patch and it helped me.
>
>  Actually, I find that that is a truly awful habit and I wish that people
>  would *not* do it that way.  There are two reasons why not:
>
>  * no permanent archive of the submitted patch
>

Yes.  I can see how posting a URL to a patch would be convenient, but
having the permanent record of the patch as submitted is important.

What about uploading patches to the wiki?  That way we have the
permanent record (change history), as well as the single authoritative
location for fetching the latest version.

>  * reviewer won't know if the submitter changes the patch after he
>  downloads a copy, and in fact nobody will ever know unless the submitter
>  takes the time to compare the eventual commit to what he thinks the
>  patch is
>

Well, as long as you send another message to the lists saying "I've
uploaded a new version of the patch, that URL again is <>".  If you
just silently update the patch without telling anybody you're bound to
run into problems.

Cheers,
BJ