X-Original-To: pgsql-advocacy-postgresql.org@localhost.postgresql.org
Received: from localhost (unknown [200.46.204.144])
	by svr1.postgresql.org (Postfix) with ESMTP id 242713A3ACD
	for <pgsql-advocacy-postgresql.org@localhost.postgresql.org>;
	Tue,  2 Nov 2004 10:10:13 +0000 (GMT)
Received: from svr1.postgresql.org ([200.46.204.71])
	by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024)
	with ESMTP id 87448-04
	for <pgsql-advocacy-postgresql.org@localhost.postgresql.org>;
	Tue,  2 Nov 2004 10:10:03 +0000 (GMT)
Received: from imap.cs.msu.su (imap.cs.msu.su [158.250.10.39])
	by svr1.postgresql.org (Postfix) with ESMTP id 44E8C3A3B40
	for <pgsql-advocacy@postgresql.org>;
	Tue,  2 Nov 2004 10:10:02 +0000 (GMT)
Received: from [10.3.34.136] (pc724-lin.cmc.msu.ru [10.3.34.136])
	by imap.cs.msu.su (8.12.11/8.12.11) with ESMTP id iA2A9leW088300;
	Tue, 2 Nov 2004 13:09:47 +0300 (MSK)
	(envelope-from borz_off@cs.msu.su)
Message-ID: <41875C47.5010504@cs.msu.su>
Date: Tue, 02 Nov 2004 13:07:03 +0300
From: Alexey Borzov <borz_off@cs.msu.su>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.7.3) Gecko/20040910
X-Accept-Language: ru, en-us, en
MIME-Version: 1.0
To: "Joshua D. Drake" <jd@commandprompt.com>
Cc: Josh Berkus <josh@agliodbs.com>, pgsql-advocacy@postgresql.org
Subject: Re: [pgsql-www] PostgreSQL.org Design Proposal
References: 
 <E7F85A1B5FF8D44C8A1AF6885BC9A0E4306E8F@ratbert.vale-housing.co.uk>
	<200410291003.40276.josh@agliodbs.com>
	<41827D2A.3030505@commandprompt.com>
In-Reply-To: <41827D2A.3030505@commandprompt.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: ClamAV 0.80/566/Sun Oct 31 22:06:02 2004
	clamav-milter version 0.80j on imap.cs.msu.su
X-Virus-Status: Clean
X-Virus-Scanned: by amavisd-new at hub.org
X-Spam-Status: No, hits=0.7 tagged_above=0.0 required=5.0 tests=HTML_40_50,
	HTML_MESSAGE, HTML_TAG_BALANCE_TABLE
X-Spam-Level: 
X-Archive-Number: 200411/13
X-Sequence-Number: 5662

Hi,

Joshua D. Drake wrote:
> 
>> Gavin Roy is currently working on a system, Framewerk, which may 
>> become a better fit for our community once he gets 
>> export-to-static-html working.   Actually, we could probably use it 
>> for Techdocs right now.   
>>
> We are also considering it for the plPerlNG and plPHP sites.
> We are waiting for it to stabilize (in terms of schema changes etc..)
> a bit first.
> 
> BTW I don't know if anyone noticed but FrameWerk was a prizewinner with
> the PHP 5 coding contest.. so go Gavin.

Yes, it has achieved a whopping 18th place (out of 50).

I've downloaded Framewerk and gave it a quick review. There are some Bad 
Code Smells that will make it hard to manage in the long run:

1) HTML generated as PHP strings;
   It is not necessary to use some "template engine" but code generating 
data structures for output should be separate from code outputting this 
data which can be e.g. HTML file with minimal PHP. Changing the design 
done in the following way is *extremely* difficult:

       $ret .= "\n<form name='edit' action='$this->action' 
method='$this->method'>\n";
       $ret .= "<blockquote><table class='form' width='98%' border='0'>\n";
       foreach($this->fields as $field)
       {
         $ret .= "  <tr valign='top'>\n";
         $ret .= "    <td class=\"formitem\"";

2) Usage of homegrown i18n solution rather than some established ones
   Isn't it obvious from the first glance what this string does?
   {!i18n:visitors:{@visitors}}

3) Abstraction of DB API rather than usage of proper data access layer
   This is BTW the reason for poor PostgreSQL support in most PHP 
applications: their authors use such "abstraction layers", but design 
schema for MySQL and then just do minimal "translation" of queries they 
do. Upper levels should know nothing about SQL and just call lower level 
to fetch some data.

4) Lack of consistent coding standards.
   One can say many bad things about PEAR, but its code is at least 
readable and one always knows where to find things.