X-Original-To: pgsql-www-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 853443A42E5 for ; Wed, 17 Nov 2004 10:04:06 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 00807-04 for ; Wed, 17 Nov 2004 10:03:59 +0000 (GMT) Received: from imap.cs.msu.su (imap.cs.msu.su [158.250.10.39]) by svr1.postgresql.org (Postfix) with ESMTP id CEB963A407E for ; Wed, 17 Nov 2004 10:03:56 +0000 (GMT) Received: from [10.3.34.136] (pc724-lin.cmc.msu.ru [10.3.34.136]) by imap.cs.msu.su (8.12.11/8.12.11) with ESMTP id iAHA3swJ093457; Wed, 17 Nov 2004 13:03:54 +0300 (MSK) (envelope-from borz_off@cs.msu.su) Message-ID: <419B2170.2010109@cs.msu.su> Date: Wed, 17 Nov 2004 13:01:20 +0300 From: Alexey Borzov User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.3) Gecko/20040910 X-Accept-Language: ru, en-us, en MIME-Version: 1.0 To: Omar Kilani Cc: pgsql-www@postgresql.org Subject: Re: [PATCH] Language selection based on browser preference, References: <419861EB.1000801@tinysofa.org> In-Reply-To: <419861EB.1000801@tinysofa.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.80/588/Mon Nov 15 03:06:21 2004 clamav-milter version 0.80j on imap.cs.msu.su X-Virus-Status: Clean X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.0 tagged_above=0.0 required=5.0 tests= X-Spam-Level: X-Archive-Number: 200411/232 X-Sequence-Number: 5963 Hi, Omar Kilani wrote: > Attached patch: > > * Picks a language based on the actual browser preference. > * Makes all pages default to UTF-8. > * Adds language direction support. > * Makes pages tell the browser what language they're in. > * Fixes language_map. > * Adds a couple of extra handy language functions. I have some questions regarding the patch: 1) What's the purpose of adding the encoding to the HTML? It's already defined in .htaccess and having it in HTML may lead to some problems. 2) All files are expected to be in UTF-8, so is there a reason to encode Cyrillic letters in HTML entitites? 3) The language_from_accept_language() function does not seem to handle quality values for preferred languages, as described f.e. here: http://httpd.apache.org/docs/content-negotiation.html