Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-www-owner+archive@lists.postgresql.org>)
	id 1mf1LS-0003bi-Gl
	for pgsql-www@arkaria.postgresql.org; Mon, 25 Oct 2021 14:53:02 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-www-owner+archive@lists.postgresql.org>)
	id 1mf1LR-0003tX-EA
	for pgsql-www@arkaria.postgresql.org; Mon, 25 Oct 2021 14:53:01 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <celestin.matte@cmatte.me>)
	id 1mf1LR-0003tO-5H
	for pgsql-www@lists.postgresql.org; Mon, 25 Oct 2021 14:53:01 +0000
Received: from ploudseeker.com ([78.199.165.48])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <celestin.matte@cmatte.me>)
	id 1mf1LO-0002Mi-Pz
	for pgsql-www@lists.postgresql.org; Mon, 25 Oct 2021 14:53:00 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cmatte.me;
	s=myselector; t=1635173576;
	bh=Jlu5n1B2WjkyyqSXmmvrhinwkExZO2MlVdT/aclfcbc=;
	h=Date:To:From:Subject;
	b=jkL9NUFECDMqirnELy5h4hiJ5BZKcYg+n+M+Dwl+5sYXazGwVbFR/JhpmP5QYhUQR
	 Po1XuFKVy95OyL1Q5o58SlNDKmziQU/TZGcTw19GmBHOpw5wuZwRUzKLTN8H+p7FdA
	 gdEmvzUDvkzDULmVancGz4U6DgTg1mAVnSGvOH3cMycfrktpW1hcGAUpNgNS3O7vnq
	 RA2peJp83wUcFCgVQ2cEvZEhjqzLWl16r62QAZK/Ti/J3PC84uycN8G9k5rvetwYdL
	 dMb2S7CKhaFazkMEhIzIfmG8nOYUQ8bCz4vtk9ycIShEi8x5GyL9lyxxlxc5cVfeJ+
	 9LruB4NyAXUZQ==
Content-Type: multipart/mixed; boundary="------------GeBSIP0IVi7DwzirtVQgimtC"
Message-ID: <4280598e-cbe7-c5d3-fbce-fefce11da5f3@cmatte.me>
Date: Mon, 25 Oct 2021 16:52:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
To: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Language: en-US
From: =?UTF-8?Q?C=c3=a9lestin_Matte?= <celestin.matte@cmatte.me>
Subject: [PATCH] pgarchives: Bugfix: allow message's parentid to be null
List-Id: <pgsql-www.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-www@lists.postgresql.org>
List-Owner: <mailto:pgsql-www-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-www>
Archived-At: 
 <https://www.postgresql.org/message-id/4280598e-cbe7-c5d3-fbce-fefce11da5f3%40cmatte.me>
Precedence: bulk

This is a multi-part message in MIME format.
--------------GeBSIP0IVi7DwzirtVQgimtC
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hello,

Upon execution of load_messages.py, when creating a new thread, I get a crash:
(Sorry about the format, I get this out of strace)

Traceback (most recent call last):\n  File \"/srv/pgarchives/local/loader/load_message.py\", lin\
e 174, in <module>\n    ap.store(conn, listid, opt.overwrite, opt.overwrite)\n  File \"/srv/pgarchives/local/loader/li\
b/storage.py\", line 232, in store\n    'rawtxt': bytearray(self.rawtxt),\npsycopg2.errors.NotNullViolation: null valu\
e in column \"parentid\" violates not-null constraint\nDETAIL:  Failing row contains (2, 2, cmatte <cmatte@[my_domain]\
.tld>, helloworld@[my_pglister_domain], , Test archive after redeployment 2, 2021-10-25 14:13:32+00, 1635171212.3\
49997.1068459.nullmailer@[my_domain], hello world\n\n\n\n, null, f, null, \\x46726f6d2068656c6c6f776f726c642d6f776\
e65722b617263686976654062..., '2':5A 'after':3A 'archive':2A 'hello':6 'redeployment':4A 'test...).\n\n

I think the way to fix this is simply to allow message.parentid to be null.

Cheers,
-- 
Célestin Matte
--------------GeBSIP0IVi7DwzirtVQgimtC
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Bugfix-allow-message-s-parentid-to-be-null.patch"
Content-Disposition: attachment;
 filename="0001-Bugfix-allow-message-s-parentid-to-be-null.patch"
Content-Transfer-Encoding: base64

RnJvbSBiYTM4NTJkZjdhNjlhMWEyNWRkMzY2ZmQzNjU3ZmNlMzc0MGNmMjNmIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qz1DMz1BOWxlc3Rpbj0yME1hdHRl
Pz0gPGdpdGxhYkBjbWF0dGUubWU+CkRhdGU6IE1vbiwgMjUgT2N0IDIwMjEgMTY6NDI6NDkg
KzAyMDAKU3ViamVjdDogW1BBVENIXSBCdWdmaXg6IGFsbG93IG1lc3NhZ2UncyBwYXJlbnRp
ZCB0byBiZSBudWxsCgpPdGhlcndpc2UsIGxvYWRfbWVzc2FnZS5weSB3aWxsIGNyYXNoIHVw
b24gY3JlYXRpb24gb2YgYSBuZXcgdGhyZWFkCi0tLQogZGphbmdvL2FyY2hpdmVzL21haWxh
cmNoaXZlcy9tb2RlbHMucHkgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o
KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kamFuZ28vYXJjaGl2ZXMvbWFpbGFy
Y2hpdmVzL21vZGVscy5weSBiL2RqYW5nby9hcmNoaXZlcy9tYWlsYXJjaGl2ZXMvbW9kZWxz
LnB5CmluZGV4IDQ0YzQ0NjkuLjg3OWQyODAgMTAwNjQ0Ci0tLSBhL2RqYW5nby9hcmNoaXZl
cy9tYWlsYXJjaGl2ZXMvbW9kZWxzLnB5CisrKyBiL2RqYW5nby9hcmNoaXZlcy9tYWlsYXJj
aGl2ZXMvbW9kZWxzLnB5CkBAIC0yNSw3ICsyNSw3IEBAIGNsYXNzIE1lc3NhZ2UobW9kZWxz
Lk1vZGVsKToKICAgICBtZXNzYWdlaWQgPSBtb2RlbHMuVGV4dEZpZWxkKG51bGw9RmFsc2Up
CiAgICAgYm9keXR4dCA9IG1vZGVscy5UZXh0RmllbGQobnVsbD1GYWxzZSkKICAgICAjIHJh
d3R4dCBpcyBhIGJ5dGVhIGZpZWxkLCB3aGljaCBkamFuZ28gZG9lc24ndCBzdXBwb3J0IChl
YXNpbHkpCi0gICAgcGFyZW50aWQgPSBtb2RlbHMuSW50ZWdlckZpZWxkKG51bGw9RmFsc2Us
IGJsYW5rPUZhbHNlKQorICAgIHBhcmVudGlkID0gbW9kZWxzLkludGVnZXJGaWVsZChudWxs
PVRydWUsIGJsYW5rPUZhbHNlKQogICAgIGhhc19hdHRhY2htZW50ID0gbW9kZWxzLkJvb2xl
YW5GaWVsZChudWxsPUZhbHNlLCBkZWZhdWx0PUZhbHNlKQogICAgIGhpZGRlbnN0YXR1cyA9
IG1vZGVscy5JbnRlZ2VyRmllbGQobnVsbD1UcnVlKQogICAgICMgZnRpIGlzIGEgdHN2ZWN0
b3IgZmllbGQsIHdoaWNoIGRqYW5nbyBkb2Vzbid0IHN1cHBvcnQgKGVhc2lseSkKLS0gCjIu
MzMuMQoK
--------------GeBSIP0IVi7DwzirtVQgimtC--