Received: from localhost (maia-5.hub.org [200.46.204.182]) by postgresql.org (Postfix) with ESMTP id D87359FB39E for ; Wed, 4 Apr 2007 19:26:41 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.182]) (amavisd-maia, port 10024) with ESMTP id 72694-01 for ; Wed, 4 Apr 2007 19:26:27 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.4 Received: from sd-2317.dedibox.fr (sd-2317.dedibox.fr [88.191.17.192]) by postgresql.org (Postfix) with ESMTP id 1240A9FB44F for ; Wed, 4 Apr 2007 19:26:30 -0300 (ADT) Received: from sd-2317.dedibox.fr (localhost.localdomain [127.0.0.1]) by sd-2317.dedibox.fr (Postfix) with ESMTP id E8ECFAABC; Thu, 5 Apr 2007 00:30:06 +0200 (CEST) Received: from [192.168.10.64] (ASte-Genev-Bois-153-1-80-210.w86-203.abo.wanadoo.fr [86.203.226.210]) by sd-2317.dedibox.fr (Postfix) with ESMTP id 9C4E6AAB7; Thu, 5 Apr 2007 00:30:06 +0200 (CEST) Message-ID: <46142629.2090101@lelarge.info> Date: Thu, 05 Apr 2007 00:26:49 +0200 From: Guillaume Lelarge User-Agent: Thunderbird 2.0b2 (X11/20070116) MIME-Version: 1.0 To: Magnus Hagander Cc: pgsql-www@postgresql.org Subject: Re: Typos fixes and an accesskey References: <46118E2E.7000706@lelarge.info> <46141C4F.3070901@hagander.net> In-Reply-To: <46141C4F.3070901@hagander.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200704/8 X-Sequence-Number: 11758 Magnus Hagander a écrit : > Guillaume Lelarge wrote: >> Hi, >> >> I send again my patchs because they don't seem to appear on the mailing >> list. I just hope you won't receive the two same messages. >> >> You'll find attached a .tar.gz which contains two patches. >> >> >> The first one, typos.patch, fixes a few typos I found while translating >> the templates. Please, review them because I'm not a native english >> speaker. > > This patch appears to contain a whole lot of changes that are just > whitespace (such as the indention). That makes it much harder to find > out what has really changed. Can you submit it without the whitespace > changes? > I don't remember there was a lot of whitespace changes. I'll take a look and re-submit it. > >> The second one, searchaccesskey.patch, adds an accesskey (q) for the >> search text box field. It's a quick way to access this text box. You can >> change the key if you want but I would really like to see an access key >> on this field. > > I'm not really sure about what you can and can not do with accesskeys, > but is there a particular reason you chose "q" for the search feature? > Seems like "s" would be a more logical choice? > An access key is just a shortcut. On firefox, I think you have to use Alt-Shift and the key. For example, with this patch Alt-Shit-q and your cursor goes to the search text field. q for query, q is the id of the field (not really a good reason :) ). s is fine for me :) I don't mind which letter is used as long as there's an accesskey. -- Guillaume.