Date: Sat, 05 May 2007 16:24:38 +0200
From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Subject: Re: New idea for patch tracking
In-reply-to: <200705050200.l4520Pb07412@momjian.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Message-id: <463C93A6.4040401@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
References: <200705050200.l4520Pb07412@momjian.us>
User-Agent: Thunderbird 1.5.0.8 (X11/20061204)

I would like to add one point:

Bruce Momjian wrote:

> 
> Patch committers check several things before applying a patch:
> 
> 1)  Follows the SQL standard or community agreed-upon behavior
> 2)  Style merges seamlessly into the surrounding code
> 3)  Written as simply and efficiently as possible
> 4)  Uses the available PostgreSQL subsystems properly
> 5)  Contains sufficient comments
> 6)  Contains code that works on all supported operating systems
> 7)  Has proper documentation
> 8)  Passes all regression tests

   8.5) Contains regression test(s) which covered performed changes

> 9)  Behaves as expected, even under unusual cirumstances
> 10)  Contains no reliability risks
> 11)  Does not overly complicate the source code
> 12)  If performance-related, it should have a measureable performance benefit
> 13)  Is of sufficient usefulness to the average PostgreSQL user
> 14)  Follows existing PostgreSQL coding standards
> 


	Zdenek