Message-ID: <47DB02DD.6030203@hagander.net>
Date: Fri, 14 Mar 2008 23:57:33 +0100
From: Magnus Hagander <magnus@hagander.net>
User-Agent: Thunderbird 2.0.0.12 (X11/20080213)
MIME-Version: 1.0
To: Guillaume Lelarge <guillaume@lelarge.info>
CC: PostgreSQL www <pgsql-www@postgresql.org>
Subject: Re: Patch to make some strings available to translations
References: <47DAF7E3.8070502@lelarge.info> <47DAFAF6.80204@lelarge.info>
In-Reply-To: <47DAFAF6.80204@lelarge.info>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Guillaume Lelarge wrote:
> Guillaume Lelarge a écrit :
>> I already sent this patch a few months before, but didn't get an 
>> answer on it. So, I updated it and hope for the best :)
>>
>> Anyways, a few words on one file of this patch. I had to change 
>> system/global/pgpage.php in two ways.
>>
>> First, to add '.UTF-8' to the locale. Without, I couldn't get any 
>> gettext translation to work. I wonder if Adrian had to do the same for 
>> his translation. I don't think the way I did it is absolutely right, 
>> so I would like comments on this.
>>
>> Second, base_href is set to http://www.postgresql.org/, making any 
>> links go to the official website. I'm wondering why we didn't use the 
>> value of $_SETTINGS['hosted_url'] for example as it can be a local 
>> setting.
>>
>> Any comments ? better ways to solve these ?
>>
> 
> I forgot something. "tools/schema.sql" seems to be the schema of the 
> pgweb database. Unfortunately, it doesn't seem up to date... at least, 
> the organisation column is missing on the events table.

Yeah, that's a known problem. I'm working with JD (I hope) to get it set 
up so it'll automatically be committed there from the production db.

//Magnus