public inbox for [email protected]  

help / color / mirror / Atom feed

From: Guillaume Lelarge <[email protected]>
To: Magnus Hagander <[email protected]>
Cc: PostgreSQL www <[email protected]>
Subject: Re: Patch to make some strings available to translations
Date: Sun, 16 Mar 2008 23:29:48 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

Magnus Hagander a écrit :
> Guillaume Lelarge wrote:
>> [...]
>> Second, base_href is set to http://www.postgresql.org/, making any 
>> links go to the official website. I'm wondering why we didn't use the 
>> value of $_SETTINGS['hosted_url'] for example as it can be a local 
>> setting.
> 
> This is intentional. If you end up on wwwmaster by a link, you should 
> automatically be sent back to the www mirrors.
> 
> You can control this by setting the ISMASTER variable from your apache 
> configuration. Set it to "1" and there will be no base href set. For 
> example, the config on wwwmaster has:
> 
> # When accessed locally, don't set BASE HREF, because that would break
> # the static mirrors. When accessed dynamically, set it so we don't
> # load the dynamic server with static requests.
>         SetEnvIf Remote_Addr "^(127|217\.196\.146\.204)" ISMASTER=1
> 
> 
> In the apache config.
> 

OK, works great with this.

>  > Any comments ? better ways to solve these ?
> 
> I assume it's a typo that you included a patch for .htaccess there? If 
> not, then that part certainly looks wrong :-)
> 

You're right, it's a typo. Sorry about this.

> I assume you have tested that once these things are changed, 
> translations of them actually work? I'm particularly wondering about the 
> parts where there are template tags inside the translation.
> 

Actually, I didn't check all strings. Strictly speaking about the parts 
with template tags, I did it because I've seen other parts with template 
tags within a func_lang function call. I'll check more deeply... but I 
think it will be harder because many of them depend on the search 
functionality. Anyways, I'm working on it...

Thanks for your comments.


-- 
Guillaume.
  http://www.postgresqlfr.org
  http://dalibo.com

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Patch to make some strings available to translations
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox