public inbox for [email protected]  

help / color / mirror / Atom feed

Issue report: search function not working for private lists
2+ messages / 2 participants
[nested] [flat]

* Issue report: search function not working for private lists
@ 2021-11-04 09:41  Célestin Matte <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Célestin Matte @ 2021-11-04 09:41 UTC (permalink / raw)
  To: [email protected]

There are several issues that prevent the correct installation of search functions for private lists:
- it is only possible to define a single archive search server in pgweb's settings.py, which makes it impossible to define both a public and a private archives server,
- there does not seem to be any kind of permissions verifications in pgweb/search/views.py that would allow only users subscribed to a list to search into it.

I've been told that this functionality did not indeed work for postresql.org's private lists.
-- 
Célestin Matte





^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Issue report: search function not working for private lists
@ 2021-11-04 10:25  Magnus Hagander <[email protected]>
  parent: Célestin Matte <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Magnus Hagander @ 2021-11-04 10:25 UTC (permalink / raw)
  To: Célestin Matte <[email protected]>; +Cc: [email protected]

On Thu, Nov 4, 2021 at 10:42 AM Célestin Matte <[email protected]>
wrote:

> There are several issues that prevent the correct installation of search
> functions for private lists:
> - it is only possible to define a single archive search server in pgweb's
> settings.py, which makes it impossible to define both a public and a
> private archives server,
> - there does not seem to be any kind of permissions verifications in
> pgweb/search/views.py that would allow only users subscribed to a list to
> search into it.
>
> I've been told that this functionality did not indeed work for
> postresql.org's private lists.
>

Yes, this is a known limitation. This is "documented" in a code comment:

def search(request):
    if not settings.PUBLIC_ARCHIVES:
        # We don't support searching of non-public archives at all at this
point.
        # XXX: room for future improvement
        return HttpResponseForbidden('Not public archives')


-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2021-11-04 10:25 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 09:41 Issue report: search function not working for private lists Célestin Matte <[email protected]>
2021-11-04 10:25 ` Magnus Hagander <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox