Feedback-ID: ie0a040ee:Fastmail
Message-ID: <68a4435c-3990-419d-a68a-b33a7f9185ab@eisentraut.org>
Date: Wed, 8 Jan 2025 14:39:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Moving the vacuum GUCs' docs out of the Client Connection
 Defaults section
To: Melanie Plageman <melanieplageman@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
References: 
 <CAAKRu_aQUOaMYrcjNuXeSkJtaX9oRUzKP57bsYbC0gVVWS+cbA@mail.gmail.com>
 <1373018.1736213217@sss.pgh.pa.us>
 <CAAKRu_bz3BD4w0jmjfQkckAQE5eb-Ge2a=9Q-HG_rWSTeG_PzA@mail.gmail.com>
 <CAAKRu_Ymux_RBzp5faSR5-qx1JdM6qS3POVjcWyHbnQjzgmo8g@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAAKRu_Ymux_RBzp5faSR5-qx1JdM6qS3POVjcWyHbnQjzgmo8g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/68a4435c-3990-419d-a68a-b33a7f9185ab%40eisentraut.org>
Precedence: bulk

On 07.01.25 18:31, Melanie Plageman wrote:
> On Tue, Jan 7, 2025 at 12:15 PM Melanie Plageman
> <melanieplageman@gmail.com> wrote:
>>
>> Cool, I've attached a patch to do this. I left a few of the GUCs under
>> Resource Consumption (like autovacuum_work_mem and
>> vacuum_buffer_usage_limit) where they are because it seemed
>> appropriate.
>>
>> This is my first docs patch that introduces new sections and such, so
>> I'm not sure I got the indentation 100% correct (I, of course, tried
>> to follow conventions).
> 
> Oh, one thing I forgot to say. Though I increased the indentation of
> some of the subsections that I moved, I didn't rewrap the lines
> because they were already not wrapped to 78. I can do this, but I
> can't tell from the existing docs what text width the paragraphs of
> text are supposed to be wrapped to.

For a patch that moves things around like this, I would leave everything 
as is and not rewrap.  That makes it easier to follow what's going on 
with "git diff -w", "git show -w" etc.

In .dir-locals.el, there is this configuration for Emacs:

  (nxml-mode . ((fill-column . 78)
                (indent-tabs-mode . nil)))

So that's one data point about what the line length should be.