From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: Postgres 11 release notes
To: Bruce Momjian <bruce@momjian.us>, Peter Geoghegan <pg@bowt.ie>
Cc: Teodor Sigaev <teodor@sigaev.ru>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <20180511150852.GA18510@momjian.us>
 <f88a4718-7d0c-b05c-7fde-90b23b3c1892@sigaev.ru>
 <20180511184406.GD18510@momjian.us>
 <aebf5f72-02a2-61e1-008f-525169e48474@sigaev.ru>
 <20180511210652.GK18510@momjian.us>
 <CAH2-WzkBcFCZGGFk7YAcBJ1v6hU3SBZFSD1AqrHxMQm_xknkDA@mail.gmail.com>
 <20180513004708.GA15365@momjian.us>
Message-ID: <6a28a9c2-d1aa-966c-e1f4-848750de2189@2ndQuadrant.com>
Date: Mon, 14 May 2018 07:47:54 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20180513004708.GA15365@momjian.us>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Precedence: bulk


On 05/12/2018 08:47 PM, Bruce Momjian wrote:
> On Sat, May 12, 2018 at 01:22:55PM -0700, Peter Geoghegan wrote:
>> On Fri, May 11, 2018 at 2:06 PM, Bruce Momjian <bruce@momjian.us> wrote:
>>> Done and URL updated.
>> I have some feedback on "Allow NOT NULL to be added to columns without
>> requiring a table rewrite". I suggest that this be phrased as "Avoid a
>> table rewrite when ALTER TABLE ADD COLUMN sets a default value for a
>> column". Referencing the fact that Postgres was previously able to do
>> this with a NULL default doesn't seem to add anything.
> Agreed, done:
>
>         Allow <command>ALTER TABLE</command> to add a non-null default
>         column without a table rewrite (Andrew Dunstan, Serge Rielau)
>


I think "a column with a non-null default" would be a bit clearer than
"a non-null default column".

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services