Message-ID: <6fc41ae5-f547-4cbd-a2d5-54ad75e33fe5@cmatte.me>
Date: Mon, 12 Feb 2024 21:48:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: PostgreSQL WWW <pgsql-www@lists.postgresql.org>
Content-Language: en-US
From: =?UTF-8?Q?C=C3=A9lestin_Matte?= <celestin.matte@cmatte.me>
Subject: Patches waiting for review/integration (pglister, pgarchives, pgweb)
Autocrypt: addr=celestin.matte@cmatte.me; keydata=
 xsFNBFQipO8BEADUvqE27QFRLuew+jnzTi1HupltXE+mcFXkCE3ksU4UIMpUDHud+Uje6HIA
 dHQuq4ovTZOrCsE6cmwZ7HXjG3/fwCTsmlL+/VlJM+ip3l4vAnlL9CaN1iPGERfiYEgyQ80J
 GeEaPAo4wPyuU/qE0OkBFsb25lyyfpycd6GZXCWEj2/lJtWqkRLx9S9kNms6PlbOGw2KBaeL
 H9a778Gk73ELkaV/rTmLISZSy5KFszHnesZeNCIwjJdiEPvrhR1W/Nux1h8ac1fUzmbGXoLv
 2dCskYX8DHCTzEEDJs+jnS3JVcWA39DDWnpdkLCy8/dKFJtnC/bw8dAryAIyqtSERJhJ5k7r
 hTr2t7EMwkh+mjTgYc8ixxkUEeHmTz3QMgnWBaKB/GhNPrdlJEmPxdQnTftA5kek9hfcmdCR
 mitOZkrqq0N55i/PPb5YFCEMuEWDkJLdRN+oyQy4zz4qdqHxhLqNnVrKx56kuHCEvD8rMvJg
 qrBei2rmr/rXhLGqk5l8iTfNZNJBRDCTT2S+i07U8bHuRpFH7R80pdBgyvJM3JViA1EbxDxS
 aGrK9PcWnxSgdex+hYN3bNHsK3CLMcMf94fbZIpATDM28tgKFjiCWJq1z+EaWuV48LBRanxF
 wqMj/YhG7ydcWj+KD1tjhb3c5sPqxoFF7ZMA4SiquUO+1Qis9wARAQABzSpDw6lsZXN0aW4g
 TWF0dGUgPGNlbGVzdGluLm1hdHRlQGNtYXR0ZS5tZT7CwY4EEwEIADgWIQRkMBVsWP+VuH6p
 DzChpij+y2qL1gUCX140dAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRChpij+y2qL
 1rnREADUGn7UXdUl2pyFlaIErGT17tulBh854Q43ePV27JDlOabh0csk6WyB18bYn9PhA4es
 liF6LFYOGdJPO+t1qodfxthZjZksVPb4cqR/Q/EL135zZ069Jg0P7kcmSyEeFq0iUSCVL4wN
 YYF+lCpKVvwkt9cD3vqxGi0zacO0aKBYlG/KNTTYNKC606FmTS75jtoJeQEpQE/eQpDqPACC
 nBMoyJZyDfXyIkg02lWQTrLjMa5U6G0+iH00pjadgaUeB3OpvIYaMFxMfKodnWEgTx21aY1m
 HFa8MSM1uSW6NFLXjTKxCxEzQtkwOLiOpvIf+Kjxe1VLcb39ulMs9JBxAYJAfpaUO+u/sPGf
 N6NexjVjJlaV153wdAjcOycDk1UXhqHwMh4i7Um6pjftyqAhT25/CPD+O2A68vn852Taw/Bx
 cbIbJ3uDxluR5/J0eIwiLzP4cMRa+0av2Xt7UqqN/RCx0owvlILpHkxH/3Buzu505pNqNs3Y
 7ZnViYRe0cQpfdQOOfjtSV2gFx/e6jcF47dUGSqCogCAfn9j8HpmsAsXnMS4g9548CKc7ByY
 HZNXAuRZmywRrCP+kyNB/No4uaMvNzGbaCtva3Ui9DEI01IAoZ2GILEGOlmHCXO6QLDLW+lH
 /N0fgKv40D6vR9ysq0BuRHeJmHCRLhhBRZHSy8U9Ls7BTQRUIqTvARAA3h2d22LoJs9UboUg
 oBIIBS7D5NV2sfUbt3j8fotgaKWT2Y4UJJx8hBdyfkdUa6++yaGk92EBN8vs4BLd1zRj/izX
 Ai3sbyb+lzXs7e/DwAX5vZveGQn7fYc14ST72fLIE/B2k1V+syoi4bhoueCWnprSEwYNWhbg
 POQMFyOvUhglEeqLGhijnIQatYzwmoli6QhRip4wx5FfSYS0cgjD/uFZPnLxKvq7Cn39Hbe7
 4k5atJRC2YD1aFysjGzPm1mr0H+JCjJpN3b7VlDrYtpwEfc77F6txKGFVonS66P4Xn2+n3A4
 mBUqn3GXe2DkJACnS6NS//wWUj6nxn1vxbTLrhyvYVSMKksZ09jfBT4poN/yGawhleMwEF2i
 sXMDu2tmNb8wwTsj6Je9ibi2xs6E7gohZnGSnWx7dgnlUyKAQvmEsE8Z2wC3T2FppeobzY3Y
 t+Isj3wFYWMpp9Ijsk9IMjIkyFs1ii/OA8zsXlpT1Jsok39KkZQGJ9xaRm79+mHM6t7b2tR2
 LmtqypIqOsg8PukIK83oVP2BQQHwBCOf8LoVJZp6Q2Zt/mhkHm1+2C2ajGKeoEWcc0wd2FiC
 LHSYPplT+a5Gf2Cxlk9wgtGBa7X4YZq1btXFJebwC9UOHaTG9suFDYUJkIC48/mm7MRdZgjd
 el/Ip0nLP6qfkmVcWm0AEQEAAcLBXwQYAQIACQUCVCKk7wIbDAAKCRChpij+y2qL1qyZD/9q
 WaxEuYW2SM9hUaHnnERfmlnJAT6EmRU2uRXm5pGg3kbS6GcjiFnByLK8U9syA7j1XNIB/R/c
 442R5o1tAd0kEYq9pLk80Nkc8oULOBHgMs8FJSWpgVYJ7Qxfgg9geKXwjjljhdM2SCB214s1
 oIml3MiE91se7JSPAfMnomTdXRQMuphFF4ETw7Dd134AmhpAcXj6PeCXWmQJh4iPmJCy6K2t
 +Gbe7xyc9f6ok4zIEeZGDWyKctKgCQv07vVB5qFhxbk60AGWHjKSBTKLB8EhA2nriWIpJqPM
 Ng1DdFuBiBuWwLo29whT66XC8zdtfqbcDh4bRG7KaarOB0nbrYvifOQRB/ijnjn9xssaSdWy
 8+ea2vSamjCXDb0wWl1itDa61iUsiiPiB2UP7PrI75rI+oHRDBy8AK3IYkby0IkI3nD+8wKf
 7eeHao1vG/r6E8PhJ1KbMtHkxwV/iSVRoETR8+vcsYP4Rh5HHlc7ERUWgN4Cgyk/WZd4RwNa
 E7jwD00hpkxgbHNoXXVvYlzRKWpIQnBzEKc+46JsRie91/YrxOkm123PoWGasOCzinr5r3uT
 lHrvULo7IsHw+1Ru29cne8BH9+FKxup4B2SYJ6RjZFwd+8dan2DW7dqjA2d8l2/CgQgL7Hqq
 co++UjjOPJT3t7qY4ekbQ3xf6bdSDZh7Aw==
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/6fc41ae5-f547-4cbd-a2d5-54ad75e33fe5%40cmatte.me>
Precedence: bulk

Hello,

I've been sending patches for pglister and pgarchives since 2021, and some of them seem to have been overlooked.
Would it be possible to have a feedback on these patches, or pushing the ones already reviewed to master?
Hopefully this list will help sorting through the opened discussions.

- pglister: make organization name generic
https://www.postgresql.org/message-id/cbd18681-4bb0-d4d2-50f8-14ed20e1dddf@cmatte.me
Final patches here: https://www.postgresql.org/message-id/9bea3703-57a6-db28-907a-465fb891a44a%40cmatte.me
Status: General idea was approved, final series of patches did not get a response

- pgarchives: Bugfix: missing ids in pglister_sync
https://www.postgresql.org/message-id/23a04b00-ab59-6460-6ce2-d845f1be666c@cmatte.me
Patch here: https://www.postgresql.org/message-id/CABUevEyo3T2QY9sEFvthmNd2vYRzUnESWZ%3Di9GaotQsyhuEQww%40mail.gmail.com
Status: Magnus wrote a patch, I tested and approved it, but it was never pushed to master
Possible commit message:
Bugfix: missing ids in pglister_sync
groupid and listid are not explicitly set in pglister_sync's queries, which
causes the script to fail as these fields are NOT NULL and postgresql default
configuration does not auto-fill id fields.

- pglister: Add README.md and INSTALL.md
https://www.postgresql.org/message-id/6f092810-5625-1f47-34f8-3522193a5cc1@cmatte.me
Status: never got a review

- pgarchives: Always load auth, even when using PUBLIC_ARCHIVES=True
https://www.postgresql.org/message-id/bb55b32a-c744-d770-fb7e-4df090175a17@cmatte.me
Final patch here: https://www.postgresql.org/message-id/846c9d77-bfff-19e3-9622-eaad5f9bf7b0%40cmatte.me
Status: New patch sent following review, but never reviewed/integrated

- pgarchives: Add search front-end from pgweb
https://www.postgresql.org/message-id/1d65043e-ef91-77d0-0c2f-2c51af5af1e5@cmatte.me
Status: It was acknowledged that there could be an interface in the archives code, but this patch was never reviewed (it's a big patch)

- pgarchives: merge schema.sql into Django's model
https://www.postgresql.org/message-id/12eb75f0-3fc2-14f3-0931-4f29e145f182@cmatte.me
Final patches here: https://www.postgresql.org/message-id/a31a7071-7338-4423-a8e5-16d70f19c2c8%40cmatte.me
Status: I've been told that this big patch should be written in place of smaller ones that fixed existing issues. I've had this in production for two years and fixed issues that have arisen. It's working great now. Still waiting for a review.

- auth.py: make it possible to customize email address in error message
pgweb: https://www.postgresql.org/message-id/79ee1e4d-ef04-414e-a5e0-1732590ff763@cmatte.me
pglister & pgarchives: https://www.postgresql.org/message-id/ae313e50-5ae1-4285-af2b-9d4b48b2f76a%40cmatte.me
Status: Got a response on the first patch, waiting for review/integration for all of them

- pglister: gitlab-ci: bump tool for syntax checking
+ pgarchives: Convert tools/ scripts to python3
https://www.postgresql.org/message-id/152870d5-4443-4a72-aabd-ee3506447926%40cmatte.me
Status: I sent these corrective patches to address comments, but they were not integrated
I also still think that the gitlab CI in the original message would help to quickly detect issues

- pgarchives & pglister: pglister_sync: import lists with subscriber_access set to True
https://www.postgresql.org/message-id/1d060463-e562-7783-decd-b5a7f3c4c06c@cmatte.me
Final patches here: https://www.postgresql.org/message-id/a99938be-c9ad-8d94-0a16-8305e6391f1e%40cmatte.me
Status: I just relaunched the discussion as the patches I sent did not satisfy requirements

Regards,
-- 
Célestin Matte