Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-www-owner+archive@lists.postgresql.org>)
	id 1mfRGG-0005xp-7Z
	for pgsql-www@arkaria.postgresql.org; Tue, 26 Oct 2021 18:33:24 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-www-owner+archive@lists.postgresql.org>)
	id 1mfRGF-00068x-5q
	for pgsql-www@arkaria.postgresql.org; Tue, 26 Oct 2021 18:33:23 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <celestin.matte@cmatte.me>)
	id 1mfREn-00040g-6z
	for pgsql-www@lists.postgresql.org; Tue, 26 Oct 2021 18:31:53 +0000
Received: from ploudseeker.com ([78.199.165.48])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <celestin.matte@cmatte.me>)
	id 1mfREj-0001N4-Mp
	for pgsql-www@lists.postgresql.org; Tue, 26 Oct 2021 18:31:52 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cmatte.me;
	s=myselector; t=1635273106;
	bh=QrXxiKjnxysU8uVQa62LjURSps6CEhoMGRYrH4z26Po=;
	h=Date:Subject:To:References:From:In-Reply-To;
	b=fCR29zd5N8F8owfo6aY0VpkgnwyuUJ/ecZIaKzVbg1pyh1s2He8JPsCyhQhZuFEfq
	 S2qLIVpoEIHKxNDAsCo/PmxDJJ4mf8rswSEGc4An5ujcdvpAoScyhzEnlYaZZP/M1U
	 K1xFCVGm1O8axB3g001BqBNKKBML1fN+xIrKIRDqktMjCG5RzEPmdyflKbfAwO/0lE
	 3hJ7Ld8WPuIU8ZnVlqww11jU7bhSn2fqV+z0+eblJ6dTy6W+T2VnESbcfH3Hy3xlWQ
	 oEubqTauQHgX0aL5BK/sFNIcTzcnwoYtIn/rGbV0jroE9K4/bGrbpUfg9lwlwN99jt
	 MFzA3gSaef6Pw==
Content-Type: multipart/mixed; boundary="------------GfXiFP3mqgMKMpJ73g0rutkM"
Message-ID: <723b45bd-0c14-83eb-1911-b4f481e1b74c@cmatte.me>
Date: Tue, 26 Oct 2021 20:31:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] pgarchives: Bugfix: allow message's parentid to be null
Content-Language: en-US
To: pgsql-www@lists.postgresql.org
References: <4280598e-cbe7-c5d3-fbce-fefce11da5f3@cmatte.me>
From: =?UTF-8?Q?C=c3=a9lestin_Matte?= <celestin.matte@cmatte.me>
In-Reply-To: <4280598e-cbe7-c5d3-fbce-fefce11da5f3@cmatte.me>
List-Id: <pgsql-www.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-www@lists.postgresql.org>
List-Owner: <mailto:pgsql-www-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-www>
Archived-At: 
 <https://www.postgresql.org/message-id/723b45bd-0c14-83eb-1911-b4f481e1b74c%40cmatte.me>
Precedence: bulk

This is a multi-part message in MIME format.
--------------GfXiFP3mqgMKMpJ73g0rutkM
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Attached: associated migration

On 25/10/2021 16:52, Célestin Matte wrote:
> Hello,
> 
> Upon execution of load_messages.py, when creating a new thread, I get a crash:
> (Sorry about the format, I get this out of strace)
> 
> Traceback (most recent call last):\n  File \"/srv/pgarchives/local/loader/load_message.py\", lin\
> e 174, in <module>\n    ap.store(conn, listid, opt.overwrite, opt.overwrite)\n  File \"/srv/pgarchives/local/loader/li\
> b/storage.py\", line 232, in store\n    'rawtxt': bytearray(self.rawtxt),\npsycopg2.errors.NotNullViolation: null valu\
> e in column \"parentid\" violates not-null constraint\nDETAIL:  Failing row contains (2, 2, cmatte <cmatte@[my_domain]\
> .tld>, helloworld@[my_pglister_domain], , Test archive after redeployment 2, 2021-10-25 14:13:32+00, 1635171212.3\
> 49997.1068459.nullmailer@[my_domain], hello world\n\n\n\n, null, f, null, \\x46726f6d2068656c6c6f776f726c642d6f776\
> e65722b617263686976654062..., '2':5A 'after':3A 'archive':2A 'hello':6 'redeployment':4A 'test...).\n\n
> 
> I think the way to fix this is simply to allow message.parentid to be null.
> 
> Cheers,
> 


-- 
Célestin Matte
--------------GfXiFP3mqgMKMpJ73g0rutkM
Content-Type: text/x-patch; charset=UTF-8;
 name="0002-Add-migration-associated-with-ba3852df-allow-parenti.patch"
Content-Disposition: attachment;
 filename*0="0002-Add-migration-associated-with-ba3852df-allow-parenti.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA5MDQ5YTY3NTY3YzU2OGVlM2EzNTIxN2VlNjIwZDQwY2I1NjdkOGFlIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Qz1DMz1BOWxlc3Rpbj0yME1hdHRl
Pz0gPGdpdGxhYkBjbWF0dGUubWU+CkRhdGU6IFR1ZSwgMjYgT2N0IDIwMjEgMjA6Mjk6NTgg
KzAyMDAKU3ViamVjdDogW1BBVENIIDIvMl0gQWRkIG1pZ3JhdGlvbiBhc3NvY2lhdGVkIHdp
dGggYmEzODUyZGYgKGFsbG93IHBhcmVudGlkIHRvCiBiZSBudWxsKQoKLS0tCiAuLi4vbWln
cmF0aW9ucy8wMDA1X2F1dG9fMjAyMTEwMjZfMTgyNy5weSAgICAgIHwgMTggKysrKysrKysr
KysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKQogY3JlYXRlIG1v
ZGUgMTAwNjQ0IGRqYW5nby9hcmNoaXZlcy9tYWlsYXJjaGl2ZXMvbWlncmF0aW9ucy8wMDA1
X2F1dG9fMjAyMTEwMjZfMTgyNy5weQoKZGlmZiAtLWdpdCBhL2RqYW5nby9hcmNoaXZlcy9t
YWlsYXJjaGl2ZXMvbWlncmF0aW9ucy8wMDA1X2F1dG9fMjAyMTEwMjZfMTgyNy5weSBiL2Rq
YW5nby9hcmNoaXZlcy9tYWlsYXJjaGl2ZXMvbWlncmF0aW9ucy8wMDA1X2F1dG9fMjAyMTEw
MjZfMTgyNy5weQpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi45NWU4MWVk
Ci0tLSAvZGV2L251bGwKKysrIGIvZGphbmdvL2FyY2hpdmVzL21haWxhcmNoaXZlcy9taWdy
YXRpb25zLzAwMDVfYXV0b18yMDIxMTAyNl8xODI3LnB5CkBAIC0wLDAgKzEsMTggQEAKKyMg
R2VuZXJhdGVkIGJ5IERqYW5nbyAyLjIuMjQgb24gMjAyMS0xMC0yNiAxODoyNworCitmcm9t
IGRqYW5nby5kYiBpbXBvcnQgbWlncmF0aW9ucywgbW9kZWxzCisKKworY2xhc3MgTWlncmF0
aW9uKG1pZ3JhdGlvbnMuTWlncmF0aW9uKToKKworICAgIGRlcGVuZGVuY2llcyA9IFsKKyAg
ICAgICAgKCdtYWlsYXJjaGl2ZXMnLCAnMDAwNF9yZXNlbmRfcmF0ZV9saW1pdCcpLAorICAg
IF0KKworICAgIG9wZXJhdGlvbnMgPSBbCisgICAgICAgIG1pZ3JhdGlvbnMuQWx0ZXJGaWVs
ZCgKKyAgICAgICAgICAgIG1vZGVsX25hbWU9J21lc3NhZ2UnLAorICAgICAgICAgICAgbmFt
ZT0ncGFyZW50aWQnLAorICAgICAgICAgICAgZmllbGQ9bW9kZWxzLkludGVnZXJGaWVsZChu
dWxsPVRydWUpLAorICAgICAgICApLAorICAgIF0KLS0gCjIuMzMuMQoK
--------------GfXiFP3mqgMKMpJ73g0rutkM--