Feedback-ID: ie0a040ee:Fastmail
Message-ID: <72d75070-8422-4796-9454-29ac2a8a4952@eisentraut.org>
Date: Thu, 9 Jan 2025 17:23:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Moving the vacuum GUCs' docs out of the Client Connection
 Defaults section
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>,
 Daniel Gustafsson <daniel@yesql.se>, "Bossart, Nathan" <bossartn@amazon.com>
References: 
 <CAAKRu_aQUOaMYrcjNuXeSkJtaX9oRUzKP57bsYbC0gVVWS+cbA@mail.gmail.com>
 <1373018.1736213217@sss.pgh.pa.us>
 <CAAKRu_bz3BD4w0jmjfQkckAQE5eb-Ge2a=9Q-HG_rWSTeG_PzA@mail.gmail.com>
 <CAAKRu_Ymux_RBzp5faSR5-qx1JdM6qS3POVjcWyHbnQjzgmo8g@mail.gmail.com>
 <68a4435c-3990-419d-a68a-b33a7f9185ab@eisentraut.org>
 <CAAKRu_ZR8aqiZ0SHK8Rqd7QVAmr6XX9Xpkie9vmZAkyb69YOiQ@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAAKRu_ZR8aqiZ0SHK8Rqd7QVAmr6XX9Xpkie9vmZAkyb69YOiQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/72d75070-8422-4796-9454-29ac2a8a4952%40eisentraut.org>
Precedence: bulk

On 09.01.25 02:45, Melanie Plageman wrote:
> On Wed, Jan 8, 2025 at 8:39 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> On 07.01.25 18:31, Melanie Plageman wrote:
>>>
>>> Oh, one thing I forgot to say. Though I increased the indentation of
>>> some of the subsections that I moved, I didn't rewrap the lines
>>> because they were already not wrapped to 78. I can do this, but I
>>> can't tell from the existing docs what text width the paragraphs of
>>> text are supposed to be wrapped to.
>>
>> For a patch that moves things around like this, I would leave everything
>> as is and not rewrap.  That makes it easier to follow what's going on
>> with "git diff -w", "git show -w" etc.
>>
>> In .dir-locals.el, there is this configuration for Emacs:
>>
>>    (nxml-mode . ((fill-column . 78)
>>                  (indent-tabs-mode . nil)))
>>
>> So that's one data point about what the line length should be.
> 
> Well, in this case, the diff won't look different with git show/diff
> -w because moving them to another part of the file is more than a
> whitespace change.

Correct.  The right option is

     git diff --color-moved

This can also be put into .gitconfig.