Subject: Re: Release Notes Archive Patch
To: Magnus Hagander <magnus@hagander.net>
Cc: "pgsql-www@lists.postgresql.org" <pgsql-www@lists.postgresql.org>
References: <e0f09c9a-bd2b-862a-d379-601dfabc8969@postgresql.org>
 <CABUevEwzO34DEeAhyb3SFvq4CMnuuHLJFKHjmuVAa-XeEbCTjw@mail.gmail.com>
 <bc9038eb-e61d-4cd8-4e01-0b3676d49d68@postgresql.org>
 <CABUevExFOu__h+X6YD+XtGKbv5xZKgSsxczYmJrJFo+Zb_GvCA@mail.gmail.com>
From: "Jonathan S. Katz" <jkatz@postgresql.org>
Openpgp: preference=signencrypt
Autocrypt: addr=jkatz@postgresql.org; keydata=
 mQINBFtShwABEAC7PNHDUOTYuifpUCk23KqfxdQQkn4nkoxOXRK0+rAj36FiwqGB4TJFuOVZ
 sDFAEiSlC8Jt4y5Cs7B5tetT8JNd2cs6zp/udMJJDz9d65O9PDpdlMgAmIiTzpLlSdx8FG56
 DTksaDv1d8j3cTJPSE4/fWSxqzA7o3Y9UuL7atZPrzfImgpRKs0of7elIHwOa8GucjyhYqcR
 h60wFBJc2KXqQdDYRTZy43DSnY/0VNc0omiH355fustvpm+m5HjD3w7qZyfN3fpKJpnX1LCF
 f3MnPHaDGITIYGRCBXvf0UqUtD6OEVWPv2C2gyqWMIpWmZTOgDufltKyIByKBoS9x0PlFkij
 04X3KODCngt+N8Ssc9OICc6QSxhjoP48PYPdmiTmkrGuf0LX084wj1xeo1NX7XxZK39F6dTJ
 DhsIiW0sNS0xMxQHLHG9VLbPjx3SANQBh6BuryPz5ZupW9/TIDmkvprtU/oXfKgtfYm3fxmk
 EctxbWrEPsFTFPyuMqQu6l+xyQv0s1VLZfjNWaua6H1/gGoIt6kRnn5qMXDVVpijuWkHbv7G
 ngaQMd258UrrOEHnnjzhQ7jxMWV9D+emxbAtlIxnYvCWlV4IwAQhEHfvudqYaIY3hNWrvQ6H
 GB2KXoTZYN9g5djm14/5nj1IU5zOcovkjJnKhoo9iStnpFF2cwARAQABtCdKb25hdGhhbiBT
 LiBLYXR6IDxqa2F0ekBwb3N0Z3Jlc3FsLm9yZz6JAlQEEwEIAD4CGwMFCQeGH4AFCwkIBwIG
 FQoJCAsCBBYCAwECHgECF4AWIQT6hLaVryv3miBkP/HxBJxynxxlJwUCW1KJJQAKCRDxBJxy
 nxxlJwjrD/kBgqsW4QpNpTFw7ifRokZV08CCX4huPBJQ91rrv+UEWlEcotFBHVkYyHnpzARl
 tcZxhJ9CbFxjniH9cOTty5T/O1yolbOHtZSW8Z8aWV6BVEbjMb+BFxSSLm7RnvJdzQbGCZq2
 ZZvfVpB6z3EHYph4KDdVKvMFjoLskxmdS1DE0tE3zTxvoQsi24Q+HOS07kUjs6fsu/WICMfz
 mgO++AWG9Y0CvN0mm4TkujESzyKM9E5irD+leEMIcddl51Aa2c/VMfBXQbRmpHIgUFTmuHQD
 CnQih+9i3OJAksDg66SP8a7yiXv5mwvyDi1EfTGVKYR2j+pwyjwnC3oIbvDMmB3uTn2JIjnT
 iZKPVtAcAylXjubFltihQgNyuShdP4W+kBwZizhUFqUVL8Anx+KoytYmJPfMRFLGuK4obXKq
 a2ZS3k9KB+H+isOx2nFJOsc7V360Zp1DVaNmuiK10TT6QndShSPaqkJqFtCb6r92rZ9sZM/L
 3vtCI4Rrl3Pt1MgtENXupS8gZpJnAYS0j5A1PAZ09r6ANoaeMHspF+5J5fOHeEvqphXr36mm
 a83Vl1t4orPb0+QmmijmlpseDU63M88Aw5p3c4qj7t8Qr2EZ5zrn7/sFn5wOfbs8Nymxafif
 QCnlV2vg9p0m7vSk/yLJ4PFZvs52FgqAGRCdRn0s2EC99bkCDQRbUocAARAAv8ho/toQ9DG3
 j4f9h9n1aRHr2FlviN2Utpy6L8+dfDggO0geilmkGQOolZ2E60gGfye/kUtF9W3NByO4hxDR
 9u6qbOXcdqnuA+cc68EfqlWFJrVtYFxt0h4ElWYOYnIezKthriWch/FY70FGrxs3z8UHOHq5
 0wBW433eTvZm90WixBiXEt2v1DgW4Vr3ymfO7Aap/IYyPuE4JzgudAuAl0HKPyNEHWHG1dAb
 jX1RiCw9gknIDWQOF0B4UAaJctWGVcnZ3A2ULwNGMa1P9ZJlBWf1vcj01aiHMU0yQ7JjJiSp
 vfm9eM0uSLwRdDrJjyl5ZZqVumjdv2SMNQ8GvYRbEMys3GGDSt9zXgfCSUnPnJfYxjzBHRI6
 x44Wfsx8S6hWxepOogCJJ/g67Bk9mY8YV4klWIXDJVOL5jnBC09DbsZG81JaE2QxB8Y7W36Z
 Mroi9XMxg3s805hQAQUvdG/poU8hN8BWdrnTm/+4eQQp7gDY1ePDmGM6bJC+OHOSnFtR/f+7
 0zpKJ10cc7cBygGnl1yR3KjhFyAWUFvP4ZGziKCcpMwXZfe9PGuyA/YOubMphxIn3YsK2wrd
 faKZYX2GMZCZhMMcvx9IpQrxIJgU+VlwXu/O+Lk10VIPcxPJJwmpdI6HzcS8ZgG6IMcC444X
 XTuLaP8j2mgcMvYak3ScCykAEQEAAYkCPAQYAQgAJhYhBPqEtpWvK/eaIGQ/8fEEnHKfHGUn
 BQJbUocAAhsMBQkHhh+AAAoJEPEEnHKfHGUnReMP/RA2UhGQj+G4uBshkRLjpRysabdPqgQB
 dEBk6wYbio88Wg/2/hgY7UzmDDEwX3sZfQDcrI6+vIobI8uqstZID+WgAAa1JLfChMyVQnSy
 0zfWMOABXscc5tGuvFRZvJklTissMFjXUwaREEKp4ZikTvJ/62MCjSdtrUhnPLvoTsHTKRKD
 ichE+b5A54alwsubTijw12O6N22r5IjZiiSZV0u7dsShyKw+7wCSax9fuBoE43NMYf+dnjMK
 nerAQYUcZWYMnk+EC8RaqYAxv6XZ2tKx1AkGGktwkQIBwrz9IlDSvJ3LWJ2UIIuLRTdngNgg
 GIL4zzuUa2F56FqskQIuYMaNETk6LYfalBDQ6TVLAcgCPQxp4k4i/PRsZ3lZ2ZhRHRYciOvm
 kp+I6EfHwllQpYrWs1thluBGqlJSVJgKl0IOFvKLsQ6KKfqzAwh6FxrO5qajp4viNIgtWoFw
 O5Bp0jgFTbH2OrMWIRfUdUCH1Djbuo65svhNj7FNsQVYzHDI+Nd1I/LOBoPc3UorRMF2M4JV
 kUR7skOHWUbPTSNUr7qc14NSMY3PKjGeVGAsBVHBPvmRx/Ss2tW/TpJWpxg4pmquFQSXuaYh
 Yf4FN8Sxy320pcr+FqN8AhZkYJcNY82OTtR5VEKRC/mYcyq61qXIKqngydn79bJjGxHipxyF FmEC
Message-ID: <7ec61f14-5507-c073-b25d-247befef90e2@postgresql.org>
Date: Thu, 28 Feb 2019 10:14:57 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0)
 Gecko/20100101 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: 
 <CABUevExFOu__h+X6YD+XtGKbv5xZKgSsxczYmJrJFo+Zb_GvCA@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="wVPisBWwHehDG6mgSOdvqZf9mnzMBew4S"
Precedence: bulk

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--wVPisBWwHehDG6mgSOdvqZf9mnzMBew4S
Content-Type: multipart/mixed; boundary="is9bRLByeoTkOnSKRGqgq2kkzWXoz6tjQ";
 protected-headers="v1"
From: "Jonathan S. Katz" <jkatz@postgresql.org>
To: Magnus Hagander <magnus@hagander.net>
Cc: "pgsql-www@lists.postgresql.org" <pgsql-www@lists.postgresql.org>
Message-ID: <7ec61f14-5507-c073-b25d-247befef90e2@postgresql.org>
Subject: Re: Release Notes Archive Patch
References: <e0f09c9a-bd2b-862a-d379-601dfabc8969@postgresql.org>
 <CABUevEwzO34DEeAhyb3SFvq4CMnuuHLJFKHjmuVAa-XeEbCTjw@mail.gmail.com>
 <bc9038eb-e61d-4cd8-4e01-0b3676d49d68@postgresql.org>
 <CABUevExFOu__h+X6YD+XtGKbv5xZKgSsxczYmJrJFo+Zb_GvCA@mail.gmail.com>
In-Reply-To: <CABUevExFOu__h+X6YD+XtGKbv5xZKgSsxczYmJrJFo+Zb_GvCA@mail.gmail.com>

--is9bRLByeoTkOnSKRGqgq2kkzWXoz6tjQ
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 2/28/19 7:19 AM, Magnus Hagander wrote:
>=20
>=20
> On Thu, Feb 28, 2019 at 12:30 AM Jonathan S. Katz <jkatz@postgresql.org=

> <mailto:jkatz@postgresql.org>> wrote:

>     So there could be an issue with that as we would have to carry the
>     lag/lead somehow. Not insurmountable, but given this is minimally
>     invasive, it would take a bit more complicating of that SQL query t=
hat
>     was just simplified.
>=20
>=20
> Well, for "previous" you wouldn't need SQL :) But yes, you'd need a "do=

> we have release notes for the next version" in there. But you only need=

> those on the one-page views, so it's really not that ba
>=20
> I think it's worth it, it's definitely something *I* use a lot in the
> old interface.

I'll look into adding it then.

>=20
> (And as a minor note, for the query, I don't think adding major/minor
> versions in the WHERE clause is enough to make it fast. You need to pus=
h
> it down into the actual filename in the innermost where-clause, to make=

> sure we get an index scan. Shouldn't be too hard)

Yeah...it kind of makes constructing the query a bit uglier, which is
why I avoided it. I'm happy to do it, but I think that given a) it's not
a lot of rows and b) it's going to be behind varnish most of the time
anyway that I'm not too concerned.

As a compromise, I can come up with a version that does this, and we can
decide what to do from there.

>=20
>     > 2. Links within the docs are just plain broken? E.g. the 9.6.0 re=
lease
>     > notes link to /docs/release/9.6.0/app-pg-dumpall.html which clear=
ly
>     > doesn't exist. IIRC we discussed something around this, but it
>     seems to
>     > have never made it into the patches? (It is listed in your known
>     > adjustments to be made above, but I could also not find a newer
>     patch?)
>=20
>     I could not reproduce this. The links work fine for me.
>=20
>=20
> It could be because I was on the wrong version of the patch. They do
> work in the patch you sent now.

Great.

>     > 5. In general, there's a huge amount of numbers on the index page=
=2E I'm
>     > not sure what's a good way to format it better, I normally leave
>     that to
>     > you :) But the page is not very friendly at this point with the
>     massive
>     > list of numbers you have to scroll through.
>=20
>     We could list out the major versions, then have the minor versions.=
 I'm
>     not opposed to that. See attached.
>=20
> =C2=A0
> Hmm. I'm still not sure I like that big long list of numbers offhand.

Why? It's in the specific version that you're looking for. It also makes
it easy to find the version you exactly want, instead of having to click
previous/next to find it. It's no different than:

https://www.postgresql.org/docs/9.4/release.html

In fact, it's a similar workflow:

1. Pick your major version
2. Pick your minor version
3. Enjoy a helping of release notes.

If anything, it's one less step because you don't have to go into the
specific documentation, click "Release Notes" and find them.

>=20
> In fact -- do we need a separate page? What if we just added them to
> /docs/manual/ and /docs/manual/archive/?

I strongly feel we need a separate page. It makes them so much easier to
find, and given all the hubbub let's make it easy for our users to find
the release notes, not buried somewhere.

> And then we highlight the release notes of the latest version directly
> on /docs/.=C2=A0
>=20
> And maybe add a link in the "online manuals" section out on the
> righthand side of /docs/?

I was actually thinking in the release notes themselves, we add a right
nav that shows all the minor versions for the particular major version
of the release notes.

I'll post another revision soon.

Thanks,

Jonathan


--is9bRLByeoTkOnSKRGqgq2kkzWXoz6tjQ--

--wVPisBWwHehDG6mgSOdvqZf9mnzMBew4S
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE+oS2la8r95ogZD/x8QSccp8cZScFAlx3+vIACgkQ8QSccp8c
ZSc3rA/7BzdresKrJbH7Tf+/+Bf5rCeFX5PHKHnJOBBNy1QNMpW5ZXgkzdgKd6Lo
IM+bi4hua9rhG4SYw7RsP7D6jgR2fmnr1stVK0vZJkxvteyhDVOTFlhATwl7ZjGJ
x3XHTo3XpD2O4l4Dho9r3BbO2ab3uVzbc7v4WrpoaAbVJGBs9U3yE2K9abplTcKa
ELiC2r2a2GLsOgF1S1z+7DQOP0wNbUlUjh9pSKSTOCQvfMVFT1TersJq5IIobtdm
QCQb7YpenLLRr1f1l8iwLXbjBgxXMBjtogy+d11rm3NqoHERN970WgKGAl9E4OFC
ogA2rm/149Epw6TzHX44qEBpA//CsvvGABwFTOLycobZXQQ/Mc9pnzJq3JcqGsoS
aS0JaMuGQbqmsqyaYJghaBbfsj7lBj13wRsNF1hTpICbb44X3faNVe7IyYEzedo6
wPPF+vzUuaObEXP+qX/5UAi7r9mt4fUPaHp7cUNbdw5DmI0vKI2evjBHi6zY8Kjn
Nbp9v7Nq7yQDWyIHw4QHZpyU4RPcfaHE37zLiZy+jsNH3v8LCYagwVLc9G6tLi+a
hh4fK16hBUWv/J+wEzrBBcN/BOSCT2VUhkU0WhR/DoBA8tGAIlw8hx/lesBkmlsd
U08F9PaPEmJPdBPX2yD+eku22XyAxcv20DehxWE6P9IvchETjEA=
=cmAL
-----END PGP SIGNATURE-----

--wVPisBWwHehDG6mgSOdvqZf9mnzMBew4S--